1113161 - Make ReadTheDocs the default docs_urlbase for 5.0

Status: RESOLVED WONTFIX

(Bugzilla :: Administration, task)

Description

[Gervase Markham [:gerv]]

Bug 399068 was denied for 5.0. Therefore, by default all Help links in 5.0 will be broken. I propose we default docs_urlbase to ReadTheDocs in English for the 5.0 release, so that they will not be broken. We should also add an explanation of how to change it.

(Defaulting it to something including %lang% is not a good idea, because unless the language is "fr", that will just lead to broken links again.)

Gerv

Comment 1

[Gervase Markham [:gerv]]

Attachment: Patch v.1

We don't have to worry about forwards compatibility of the "5.0" in the RTD URL, because docs_urlbase is going away in the future :-)

I do think this is the best solution to this problem for 5.0, if we can't have the patch to make it dynamic.

Gerv

Comment 2

[Frédéric Buclin]

Comment on attachment 8538537 [details] [diff] [review]
Patch v.1

I will let glob decide what to do with this bug. Easiest would have been to commit bug 399068.

Comment 3

[David Lawrence [:dkl]]

Comment on attachment 8538537 [details] [diff] [review]
Patch v.1

Review of attachment 8538537 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r=dkl

Comment 4

[:glob ✱]

(In reply to Gervase Markham [:gerv] from comment #0)
> Bug 399068 was denied for 5.0. Therefore, by default all Help links in 5.0
> will be broken.

that problem was never documented on bug 399068 -- it appeared to be a "nice to have" change that had been hanging around for 7 years, not a fix for an issue.

in light of bug 399068 actually fixing a bug, we're clear to commit that change to the 5.0 branch.  i'll update that bug.