Make ReadTheDocs the default docs_urlbase for 5.0

RESOLVED WONTFIX

Status

()

Bugzilla
Administration
RESOLVED WONTFIX
3 years ago
3 years ago

People

(Reporter: gerv, Assigned: gerv)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Bug 399068 was denied for 5.0. Therefore, by default all Help links in 5.0 will be broken. I propose we default docs_urlbase to ReadTheDocs in English for the 5.0 release, so that they will not be broken. We should also add an explanation of how to change it.

(Defaulting it to something including %lang% is not a good idea, because unless the language is "fr", that will just lead to broken links again.)

Gerv
(Assignee)

Comment 1

3 years ago
Created attachment 8538537 [details] [diff] [review]
Patch v.1

We don't have to worry about forwards compatibility of the "5.0" in the RTD URL, because docs_urlbase is going away in the future :-)

I do think this is the best solution to this problem for 5.0, if we can't have the patch to make it dynamic.

Gerv
Assignee: administration → gerv
Status: NEW → ASSIGNED
Attachment #8538537 - Flags: review?(LpSolit)

Comment 2

3 years ago
Comment on attachment 8538537 [details] [diff] [review]
Patch v.1

I will let glob decide what to do with this bug. Easiest would have been to commit bug 399068.
Attachment #8538537 - Flags: review?(LpSolit) → review?(glob)
Comment on attachment 8538537 [details] [diff] [review]
Patch v.1

Review of attachment 8538537 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r=dkl
Attachment #8538537 - Flags: review?(glob) → review+

Updated

3 years ago
Flags: blocking5.0?
Flags: approval5.0?
(In reply to Gervase Markham [:gerv] from comment #0)
> Bug 399068 was denied for 5.0. Therefore, by default all Help links in 5.0
> will be broken.

that problem was never documented on bug 399068 -- it appeared to be a "nice to have" change that had been hanging around for 7 years, not a fix for an issue.

in light of bug 399068 actually fixing a bug, we're clear to commit that change to the 5.0 branch.  i'll update that bug.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Flags: blocking5.0?
Flags: approval5.0?
Resolution: --- → WONTFIX

Updated

3 years ago
Target Milestone: Bugzilla 5.0 → ---
You need to log in before you can comment on or make changes to this bug.