111320 - No View Frame Source in Context Menu

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: ActiveX Wrapper, defect)

Description

[amutch]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.6) Gecko/20011120
BuildID:    MFCEmbed

MFCEmbed does not provide a View Frame Source in the right-click Context Menu

Reproducible: Always
Steps to Reproduce:
1. Browse to http://www.twp.waterford.mi.us/waterfordGIS/map-frames.html
2. Right-click in left or right frame
3. Context Menu does not include View Frame Source


Expected Results:  Context Menu should include View Frame Source as the
full-blown Mozilla does

Comment 1

[amutch]

From MFCEmbed build 11/21/2001

Comment 2

[amutch]

One more addition: Please also note that the following are missing:

"Open Frame in New Window"

"Show Only this Frame"

"View Frame Info" 

"Save Frame As"

If these need separate bug reports, let me know and I'll file them.

Comment 3

[Matthias Versen [:Matti]]

wfm with win2k build 20011121..

MFCEmbed only ?

Comment 4

[Boris Zbarsky [:bzbarsky]]

embedding

Comment 5

[amutch]

This is on the MFCEmbed.  I'm sure that it works on Mozilla.

Comment 6

[Adam Lock]

-> Chak

Comment 7

[Chak Nanga]

->0.9.9

Comment 8

[Johnny Stenback (:jst)]

I bet there's lots of ways to do this, here's some suggestions how this could be
done using the DOM.

To know if an element is in a frame or iframe, get it's nsIDOMWindow and if the
parent is != the element's window, the element is inside a frame or iframe.

If you have a window (or document) and want to know if it *contains* frames, you
can do that by checking if document.body (nsIDOMHTMLDocument::GetBody()) is an
nsIDOMHTMLFrameSetElement. To know if there are iframes in a document, you'll
need to look for iframe elements in the tree, or use non-public interfaces.

Comment 9

[Chak Nanga]

Attachment: Patch to add Frame related context menu items

Comment 10

[Chak Nanga]

Hi Adam/Johnny: Can i get an r=/sr= when  you get a chance...thanks

Comment 11

[Johnny Stenback (:jst)]

Comment on attachment 64556 [details] [diff] [review]
Patch to add Frame related context menu items

Does mCtxMenuCurrentFrameURL really need to be a nsAutoString, won't it be used
only when a context menu is open? If so, maybe it'll be better to make it a
nsString...

Other than that, sr=jst

Comment 12

[Chak Nanga]

mCtxMenuCurrentFrameURL is an nsString now per jst's comments...

Comment 13

[Chak Nanga]

Fix checked in...