No View Frame Source in Context Menu

RESOLVED FIXED in mozilla0.9.9

Status

Core Graveyard
Embedding: ActiveX Wrapper
RESOLVED FIXED
16 years ago
6 years ago

People

(Reporter: amutch, Assigned: Chak Nanga)

Tracking

Trunk
mozilla0.9.9
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

16 years ago
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.6) Gecko/20011120
BuildID:    MFCEmbed

MFCEmbed does not provide a View Frame Source in the right-click Context Menu

Reproducible: Always
Steps to Reproduce:
1. Browse to http://www.twp.waterford.mi.us/waterfordGIS/map-frames.html
2. Right-click in left or right frame
3. Context Menu does not include View Frame Source


Expected Results:  Context Menu should include View Frame Source as the
full-blown Mozilla does
(Reporter)

Comment 1

16 years ago
From MFCEmbed build 11/21/2001
(Reporter)

Comment 2

16 years ago
One more addition: Please also note that the following are missing:

"Open Frame in New Window"

"Show Only this Frame"

"View Frame Info" 

"Save Frame As"

If these need separate bug reports, let me know and I'll file them.
wfm with win2k build 20011121..

MFCEmbed only ?
Assignee: asa → hyatt
Component: Browser-General → XP Toolkit/Widgets: Menus
QA Contact: doronr → jrgm
embedding
Assignee: hyatt → adamlock
Status: UNCONFIRMED → NEW
Component: XP Toolkit/Widgets: Menus → Embedding: ActiveX Wrapper
Ever confirmed: true
QA Contact: jrgm → cpratt
(Reporter)

Comment 5

16 years ago
This is on the MFCEmbed.  I'm sure that it works on Mozilla.

Comment 6

16 years ago
-> Chak
Assignee: adamlock → chak
(Assignee)

Comment 7

16 years ago
->0.9.9
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.9
I bet there's lots of ways to do this, here's some suggestions how this could be
done using the DOM.

To know if an element is in a frame or iframe, get it's nsIDOMWindow and if the
parent is != the element's window, the element is inside a frame or iframe.

If you have a window (or document) and want to know if it *contains* frames, you
can do that by checking if document.body (nsIDOMHTMLDocument::GetBody()) is an
nsIDOMHTMLFrameSetElement. To know if there are iframes in a document, you'll
need to look for iframe elements in the tree, or use non-public interfaces.
(Assignee)

Comment 9

16 years ago
Created attachment 64556 [details] [diff] [review]
Patch to add Frame related context menu items
(Assignee)

Comment 10

16 years ago
Hi Adam/Johnny: Can i get an r=/sr= when  you get a chance...thanks
Comment on attachment 64556 [details] [diff] [review]
Patch to add Frame related context menu items

Does mCtxMenuCurrentFrameURL really need to be a nsAutoString, won't it be used
only when a context menu is open? If so, maybe it'll be better to make it a
nsString...

Other than that, sr=jst
Attachment #64556 - Flags: superreview+
(Assignee)

Comment 12

16 years ago
mCtxMenuCurrentFrameURL is an nsString now per jst's comments...

(Assignee)

Comment 13

16 years ago
Fix checked in...
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Component: Embedding: ActiveX Wrapper → Embedding: ActiveX Wrapper
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.