Closed
Bug 1113200
Opened 9 years ago
Closed 9 years ago
Use sysconf to obtain the page size in GonkHal.cpp
Categories
(Core :: Hardware Abstraction Layer (HAL), defect)
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: mwu, Assigned: mwu)
Details
Attachments
(1 file, 1 obsolete file)
1.67 KB,
patch
|
Details | Diff | Splinter Review |
This is a bit more portable.
Attachment #8538577 -
Flags: review?(dhylands)
Comment 1•9 years ago
|
||
Comment on attachment 8538577 [details] [diff] [review] Use sysconf to obtain the page size in GonkHal.cpp Review of attachment 8538577 [details] [diff] [review]: ----------------------------------------------------------------- ::: hal/gonk/GonkHal.cpp @@ +1355,5 @@ > // adj is in oom_adj units. > adjParams.AppendPrintf("%d,", OomAdjOfOomScoreAdj(oomScoreAdj)); > > // minfree is in pages. > + minfreeParams.AppendPrintf("%d,", killUnderKB * 1024 / page_size); nit: %d is an int. dividing by page_size declared as long makes the result as long. So technically, this should be %ld and probably the only reason this is working is because we're on a little endian machine. Either that or cast the result of the whole expression to int
Attachment #8538577 -
Flags: review?(dhylands) → review+
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8538577 -
Attachment is obsolete: true
Assignee | ||
Comment 3•9 years ago
|
||
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=7f5ac6fb5369
Keywords: checkin-needed
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7566fcba4be9
Keywords: checkin-needed
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7566fcba4be9
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•