1113210 - accessible/atk/AtkSocketAccessible.cpp: unused function 'mai_atk_socket_get_instance_private'

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

clang with warnings-as-errors fails with:

13:53.84 /home/keeler/mozilla-central/accessible/atk/AtkSocketAccessible.cpp:54:1: error: unused function 'mai_atk_socket_get_instance_private' [-Werror,-Wunused-function]
13:53.84 G_DEFINE_TYPE_EXTENDED(MaiAtkSocket, mai_atk_socket,
13:53.84 ^
13:53.84 /usr/include/glib-2.0/gobject/gtype.h:1467:60: note: expanded from macro 'G_DEFINE_TYPE_EXTENDED'
13:53.84 #define G_DEFINE_TYPE_EXTENDED(TN, t_n, T_P, _f_, _C_)      _G_DEFINE_TYPE_EXTENDED_BEGIN (TN, t_n, T_P, _f_) {_C_;} _G_DEFINE_TYPE_EXTENDED_END()
13:53.84                                                             ^
13:53.84 /usr/include/glib-2.0/gobject/gtype.h:1677:24: note: expanded from macro '_G_DEFINE_TYPE_EXTENDED_BEGIN'
13:53.84 static inline gpointer \
13:53.84                        ^
13:53.84 <scratch space>:160:1: note: expanded from here
13:53.84 mai_atk_socket_get_instance_private
13:53.84 ^

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

Drive by comment: this might get called via plugin?

Comment 2

[Trevor Saunders (:tbsaunde)]

I was going to say that I didn't think this was worth the time to fix, but then I wondered why gcc doesn't warn for this and found that this function is marked with attribute unused to shut gcc up.  So it seems like either the gobject macros need fixed, or clang is silly and warns about unused functions with attribute unused.

(In reply to David Bolter [:davidb] from comment #1)
> Drive by comment: this might get called via plugin?

no, this code is for plugins, but its just some part of the weirdo gobject rtti setup.

Comment 3

[Chris Peterson [:cpeterson]]

I wonder why neither Try nor Treeherder builds failed with this error after bug 1110031 landed. An easy fix would be to add the following to accessible/atk/moz.build:

> if CONFIG['CLANG_CXX']:
>     CXXFLAGS += ['-Wno-unused-function']

Comment 4

[Chris Peterson [:cpeterson]]

Attachment: 1113210_Wno-unused-function.patch

Suppress -Wunused-function clang warning about accessible/atk/AtkSocketAccessible.cpp's gobject macros

Comment 5

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 8538688 [details] [diff] [review]
1113210_Wno-unused-function.patch

Review of attachment 8538688 [details] [diff] [review]:
-----------------------------------------------------------------

Trevor should give this one a think.

Comment 6

[Trevor Saunders (:tbsaunde)]

Comment on attachment 8538688 [details] [diff] [review]
1113210_Wno-unused-function.patch

>+if CONFIG['CLANG_CXX']:
>+    CXXFLAGS += ['-Wno-unused-function'] # mai_atk_socket_get_instance_private

a longer comment might be nice, but whatever.

Comment 7

[Chris Peterson [:cpeterson]]

Thanks. I added a more descriptive comment like you suggested: "Suppress clang warning about unused function from gobject's RTTI macros".

https://hg.mozilla.org/integration/mozilla-inbound/rev/6db62626c126

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6db62626c126

Comment 9

[Brad Taylor]

@davidb yeah, +1 a11y plugins don't use this API.