1113277 - Incomplete app on the same domain causes in-app product error

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Payments/Refunds, defect, P3)

Description

[Kumar McMillan [:kumar]]

STR
- submit an app on domain A
- abort the submission process when you realize the manifest is wrong.
- fix the manifest and re-submit the app on domain A by starting over
- set up content ratings
- set up payments: make it free with in-app purchases
- set up in-app products
- enter a product and click save

Expected: the product should save

Actual: traceback:

Traceback (most recent call last):
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/wsgiref/handlers.py", line 93, in run
    self.result = application(self.environ, self.start_response)
  File "/Users/kumar/.virtualenvs/zamboni/lib/python2.6/site-packages/django/core/handlers/wsgi.py", line 206, in __call__
    response = self.get_response(request)
  File "/Users/kumar/.virtualenvs/zamboni/lib/python2.6/site-packages/django/core/handlers/base.py", line 194, in get_response
    response = self.handle_uncaught_exception(request, resolver, sys.exc_info())
  File "/Users/kumar/.virtualenvs/zamboni/lib/python2.6/site-packages/django/core/handlers/base.py", line 112, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/Users/kumar/.virtualenvs/zamboni/lib/python2.6/site-packages/rest_framework/viewsets.py", line 78, in view
    return self.dispatch(request, *args, **kwargs)
  File "/Users/kumar/.virtualenvs/zamboni/lib/python2.6/site-packages/django/views/decorators/csrf.py", line 57, in wrapped_view
    return view_func(*args, **kwargs)
  File "/Users/kumar/.virtualenvs/zamboni/lib/python2.6/site-packages/rest_framework/views.py", line 399, in dispatch
    response = self.handle_exception(exc)
  File "/Users/kumar/dev/zamboni/mkt/api/base.py", line 144, in handle_exception
    return super(MarketplaceView, self).handle_exception(exc)
  File "/Users/kumar/.virtualenvs/zamboni/lib/python2.6/site-packages/rest_framework/views.py", line 364, in handle_exception
    response = self.settings.EXCEPTION_HANDLER(exc)
  File "/Users/kumar/.virtualenvs/zamboni/lib/python2.6/site-packages/rest_framework/views.py", line 387, in dispatch
    self.initial(request, *args, **kwargs)
  File "/Users/kumar/.virtualenvs/zamboni/lib/python2.6/site-packages/rest_framework/views.py", line 317, in initial
    self.check_permissions(request)
  File "/Users/kumar/.virtualenvs/zamboni/lib/python2.6/site-packages/rest_framework/views.py", line 274, in check_permissions
    if not permission.has_permission(request, self):
  File "/Users/kumar/dev/zamboni/mkt/api/authorization.py", line 201, in has_permission
    return perm.has_permission(request, view)
  File "/Users/kumar/dev/zamboni/mkt/api/authorization.py", line 112, in has_permission
    return user_pk and view.get_authors().filter(pk=user_pk).exists()
  File "/Users/kumar/dev/zamboni/mkt/inapp/views.py", line 58, in get_authors
    return self.get_app().authors.all()
  File "/Users/kumar/dev/zamboni/mkt/inapp/views.py", line 54, in get_app
    app_domain=self.kwargs['origin'])
  File "/Users/kumar/.virtualenvs/zamboni/lib/python2.6/site-packages/django/shortcuts/__init__.py", line 113, in get_object_or_404
    return queryset.get(*args, **kwargs)
  File "/Users/kumar/.virtualenvs/zamboni/lib/python2.6/site-packages/django/db/models/query.py", line 313, in get
    (self.model._meta.object_name, num))
MultipleObjectsReturned: get() returned more than one Webapp -- it returned 2!
[18/Dec/2014 11:27:02] "POST /api/v1/payments/http%3A%2F%2Flocalhost%3A3000/in-app/ HTTP/1.0" 500 59

This is because the app_domain lookup does not take status into consideration. In this case, I think it should filter out status=0 (incomplete)

Comment 1

[Andy McKay]

Based on the recently announced future plans for the Marketplace to remove payments, closing these bugs.