1113299 - Hide "Mirror Tab" entry instead of disabling it when no mirroring devices are available

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[:Gijs (he/him)]

As per summary. I don't think this should be always-visible, considering most users don't actually have a device with which they can mirror. We can show them if/when they do.

Comment 1

[:Gijs (he/him)]

Attachment: hide tab mirroring feature if unavailable,

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8540149 [details] [diff] [review]
hide tab mirroring feature if unavailable,

Review of attachment 8540149 [details] [diff] [review]:
-----------------------------------------------------------------

A disabled menuitem wasn't any good for people finding out how to start using the feature. With that said, how are people supposed to find out about the feature and also how they can use it? The alternative would be to always enable the menuitem and have a sub-menuitem that when clicked goes to a Getting Started/Tour URL.

Comment 3

[:Gijs (he/him)]

Comment on attachment 8540149 [details] [diff] [review]
hide tab mirroring feature if unavailable,

Asking for ui-review per comment 2

Comment 4

[:Gavin Sharp [email: [e-mail]]]

(In reply to (Limited availability until January 6) Jared Wein [:jaws] (please needinfo? me) from comment #2)
> A disabled menuitem wasn't any good for people finding out how to start
> using the feature. With that said, how are people supposed to find out about
> the feature and also how they can use it?

I don't think we need to worry about that at this point.

> The alternative would be to always
> enable the menuitem and have a sub-menuitem that when clicked goes to a
> Getting Started/Tour URL.

Maybe later, but for now this seems like the best solution.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Gijs, based on Gavin's response let's go ahead and land this now and file a bug for any necessary changes once we get feedback from Philipp.

Comment 6

[:Gijs (he/him)]

OK:

remote:   https://hg.mozilla.org/integration/fx-team/rev/dfc93c68f9c7


By now this is on 37, and this will hit 38, so we should uplift this to Aurora, I guess. :-(

Comment 7

[:Gijs (he/him)]

Comment on attachment 8540149 [details] [diff] [review]
hide tab mirroring feature if unavailable,

Approval Request Comment
[Feature/regressing bug #]: bug 1088758
[User impact if declined]: always-disabled menuitem in the tools menu
[Describe test coverage new/current, TBPL]: nope
[Risks and why]: very low, switching it from disabled to hidden
[String/UUID change made/needed]: no

Comment 8

[:Gijs (he/him)]

(In reply to :Gijs Kruitbosch from comment #7)
> [User impact if declined]: always-disabled menuitem in the tools menu

Sorry, this should have finished:

... for most users

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dfc93c68f9c7

Comment 10

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Comment on attachment 8540149 [details] [diff] [review]
hide tab mirroring feature if unavailable,

Clearing the ui-review since this has already landed.
I didn't test the patch itself, but from the description and discussion it sounds fine.

Comment 11

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8540149 [details] [diff] [review]
hide tab mirroring feature if unavailable,

Aurora+

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a977d85d7c55