Closed
Bug 1113403
Opened 9 years ago
Closed 9 years ago
MP4Sample destructor should be virtual
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: jya, Assigned: jya)
Details
Attachments
(1 file)
1.51 KB,
patch
|
kinetik
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
You have VP8Sample the inherit from it. It's a nit as how VP8Sample is used prevent it to be an issue.
Assignee | ||
Comment 1•9 years ago
|
||
Make MP4Sample destructor virtual now that another class inherit from it
Attachment #8538831 -
Flags: review?(kinetik)
Updated•9 years ago
|
Attachment #8538831 -
Flags: review?(kinetik) → review+
Assignee | ||
Comment 2•9 years ago
|
||
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/3d9de7d79085
Comment 3•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3d9de7d79085
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Comment 4•9 years ago
|
||
Comment on attachment 8538831 [details] [diff] [review] Make MP4Sample destructor virtual Approval Request Comment [Feature/regressing bug #]: MSE [User impact if declined]: Less consistent testing, sites more likely to serve flash video. [Describe test coverage new/current, TBPL]: Landed on m-c. [Risks and why]: Minimal; virtual dtor can only be an improvement. [String/UUID change made/needed]: none.
Attachment #8538831 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
status-firefox36:
--- → affected
status-firefox37:
--- → fixed
Updated•9 years ago
|
Attachment #8538831 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•9 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•