Closed Bug 1113403 Opened 10 years ago Closed 10 years ago

MP4Sample destructor should be virtual

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla37
Tracking Flags:
Tracking Status
firefox36 --- fixed
firefox37 --- fixed

People

(Reporter: jya, Assigned: jya)

Details

Attachments

(1 file)

Make MP4Sample destructor virtual
1.51 KB, patch
kinetik
: review+
Sylvestre
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
You have VP8Sample the inherit from it.

It's a nit as how VP8Sample is used prevent it to be an issue.
Make MP4Sample destructor virtual now that another class inherit from it
Attachment #8538831 - Flags: review?(kinetik)
Attachment #8538831 - Flags: review?(kinetik) → review+
https://hg.mozilla.org/mozilla-central/rev/3d9de7d79085
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Comment on attachment 8538831 [details] [diff] [review]
Make MP4Sample destructor virtual

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing, sites more likely to serve flash video.
[Describe test coverage new/current, TBPL]: Landed on m-c.
[Risks and why]: Minimal; virtual dtor can only be an improvement.
[String/UUID change made/needed]: none.
Attachment #8538831 - Flags: approval-mozilla-aurora?
Attachment #8538831 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: