Closed Bug 1113403 Opened 5 years ago Closed 5 years ago
MP4Sample destructor should be virtual
You have VP8Sample the inherit from it. It's a nit as how VP8Sample is used prevent it to be an issue.
Make MP4Sample destructor virtual now that another class inherit from it
Attachment #8538831 - Flags: review?(kinetik)
Attachment #8538831 - Flags: review?(kinetik) → review+
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Comment on attachment 8538831 [details] [diff] [review] Make MP4Sample destructor virtual Approval Request Comment [Feature/regressing bug #]: MSE [User impact if declined]: Less consistent testing, sites more likely to serve flash video. [Describe test coverage new/current, TBPL]: Landed on m-c. [Risks and why]: Minimal; virtual dtor can only be an improvement. [String/UUID change made/needed]: none.
Attachment #8538831 - Flags: approval-mozilla-aurora?
Attachment #8538831 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.