Closed Bug 1113441 Opened 9 years ago Closed 9 years ago

[Email] "Top" appears on the top left of the screen when scrolling down email search results

Categories

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v2.0 unaffected, b2g-v2.1 unaffected, b2g-v2.2 affected)

RESOLVED FIXED
Tracking Status
b2g-v2.0 --- unaffected
b2g-v2.1 --- unaffected
b2g-v2.2 --- affected

People

(Reporter: SalvadorR, Assigned: jrburke)

Details

(Whiteboard: [2.2-exploratory-2])

Attachments

(3 files)

Attached image SmallTop.png
Description:
When searching in the search engine within the email app, if user scrolls down, "Top" will appear in tiny text on the top left corner of the screen
   
Repro Steps:
1) Update a Flame device to BuildID: 20141218040201
2) Open email app and use the search engine to pull up several emails as search results
3) Scroll down
4) Observe the text on the top left of the screen
  
Actual:
Small "Top" text appears on the top left of the screen
  
Expected: 
"Top" does not appear
  
Environmental Variables:
Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141218040201
Gaia: 58734e8a48157f99d5b733412b600c2e04c954fe
Gecko: 5c7a6294b82a
Gonk: e5c6b275d77ca95fb0f2051c3d2242e6e0d0e442
Version: 37.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
  
Notes:
  
Repro frequency: 5/5
See attached: Screenshot, Logcat
Description:
When searching in the search engine within the email app, if user scrolls down, "Top" will appear in tiny text on the top left corner of the screen
   
Repro Steps:
1) Update a Flame device to BuildID: 20141218040201
2) Open email app and use the search engine to pull up several emails as search results
3) Scroll down
4) Observe the text on the top left of the screen
  
Actual:
Small "Top" text appears on the top left of the screen
  
Expected: 
"Top" does not appear
  
Environmental Variables:
Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141218040201
Gaia: 58734e8a48157f99d5b733412b600c2e04c954fe
Gecko: 5c7a6294b82a
Gonk: e5c6b275d77ca95fb0f2051c3d2242e6e0d0e442
Version: 37.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
  
Notes:
  
Repro frequency: 5/5
See attached: Screenshot, Logcat
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(dharris)
Summary: Email] "Top" appears on the top left of the screen when scrolling down email search results → [Email] "Top" appears on the top left of the screen when scrolling down email search results
It looks like js/message_list_topbar.js's _animateState method should be clearing the l10n attributes if state is not 'message' or 'top'.  I'm assuming we're left with the l10n id set to "message-list-top-action" but the state is something else, so the CSS rule for [data-state="top"]'s "font-size: 0;" style is not applied.  (This is why we need to move to React! ;)

Besides fixing the bug, maybe we should be moving the "Top" string to an aria label or something like that so we don't need a font-size hack?
Flags: needinfo?(jrburke)
Disregard comment 2, here are the correct environmental variables:

This issue does not repro on Flame 2.0 and Flame 2.1

Results: "Top" does not appear on the top right corner of the screen

Flame 2.0

Environmental Variables:
Device: Flame 2.0 (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141219000200
Gaia: ce83ea7b8e3fa2d1c3fd771fc22b654c18b3c381
Gecko: f57067657bfa
Gonk: e5c6b275d77ca95fb0f2051c3d2242e6e0d0e442
Version: 32.0 (2.0)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Flame 2.1

Environmental Variables:
Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141219001200
Gaia: 6af3d029bae3a14f400fec0926f0f8ad7b579b4b
Gecko: d41f6bd64343
Gonk: e5c6b275d77ca95fb0f2051c3d2242e6e0d0e442
Version: 34.0 (2.1)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
Not nominating this bug to block 2.2. This appears to be a minor UI issue.
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(dharris)
Attached file GitHub pull request
This is a z-index issue, details in the pull request.
Assignee: nobody → jrburke
Status: NEW → ASSIGNED
Flags: needinfo?(jrburke)
Attachment #8544799 - Flags: review?(bugmail)
Comment on attachment 8544799 [details] [review]
GitHub pull request

I find the existence of the string as a visible thing somewhat weird and likely to have weird a10y manifestations, but since the behaviour difference is z-index based, I agree it makes sense to do this fix here and then maybe in some future effort make things less confusing for me ;)
Attachment #8544799 - Flags: review?(bugmail) → review+
Merged in master:
https://github.com/mozilla-b2g/gaia/commit/5e34286253950e5cb84f472a9ca13243a9173a8c

from pull request:
https://github.com/mozilla-b2g/gaia/pull/27170

The z-index change is definitely needed just to properly animate the hiding of the element without overlapping the search headers as it animates up. I will check the a11y behavior tomorrow and if need be file a separate bug for it, associating it with bug 893789.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: