1113458 - Optimize retrieval of pushlog data

Status: RESOLVED FIXED

(Developer Services :: Mercurial: Pushlog, defect)

Description

[Gregory Szorc [:gps]]

I found a performance optimization in the new pushlog extension. Patch forthcoming.

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: bz://1113458/gps

Comment 2

[Gregory Szorc [:gps]]

/r/1601 - pushlog: optimize retrieval of pushlog data (bug 1113458)

Pull down this commit:

hg pull review -r 938d0d2bf978ba2d712bfb441110ae67a2210d51

Comment 3

[Mike Hommey [:glandium]]

https://reviewboard.mozilla.org/r/1599/#review1001

Ship It!

Comment 4

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/e5016985d110

Comment 5

[Gregory Szorc [:gps]]

And deployed to production. Brief log inspection reveals that pushlog wireproto commands are now using only milliseconds of wall/CPU time, as expected. Thanks for the quick review!

Comment 6

[Ed Morley [:emorley]]

How does pushlog perf now compare to before we switched to the extension? Just wondering if we've helped bug 1079788 at all? Though I guess the next big win will be completing bug 1076826.

Comment 7

[Gregory Szorc [:gps]]

I don't expect perf via hgweb (json-pushes) to have changed as a result of this rewrite. However, switching consumers to version=2 and polling via startID and limiting the number of pushes returned should make a significant difference.

Also, I wrote https://mozilla-version-control-tools.readthedocs.org/en/latest/hgmo/pushlog.html#writing-agents-that-consume-pushlog-data

Comment 9

[Gregory Szorc [:gps]]

Attachment: MozReview Request: pushlog: optimize retrieval of pushlog data (bug 1113458)