Optimize retrieval of pushlog data

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: gps, Assigned: gps)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
I found a performance optimization in the new pushlog extension. Patch forthcoming.
(Assignee)

Comment 1

4 years ago
Created attachment 8538948 [details]
MozReview Request: bz://1113458/gps
Attachment #8538948 - Flags: review?(mh+mozilla)
(Assignee)

Comment 2

4 years ago
/r/1601 - pushlog: optimize retrieval of pushlog data (bug 1113458)

Pull down this commit:

hg pull review -r 938d0d2bf978ba2d712bfb441110ae67a2210d51
Attachment #8538948 - Flags: review?(mh+mozilla) → review+
(Assignee)

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

4 years ago
And deployed to production. Brief log inspection reveals that pushlog wireproto commands are now using only milliseconds of wall/CPU time, as expected. Thanks for the quick review!
How does pushlog perf now compare to before we switched to the extension? Just wondering if we've helped bug 1079788 at all? Though I guess the next big win will be completing bug 1076826.
(Assignee)

Comment 7

4 years ago
I don't expect perf via hgweb (json-pushes) to have changed as a result of this rewrite. However, switching consumers to version=2 and polling via startID and limiting the number of pushes returned should make a significant difference.

Also, I wrote https://mozilla-version-control-tools.readthedocs.org/en/latest/hgmo/pushlog.html#writing-agents-that-consume-pushlog-data
(Assignee)

Comment 8

4 years ago
Comment on attachment 8538948 [details]
MozReview Request: bz://1113458/gps
Attachment #8538948 - Attachment is obsolete: true
Attachment #8618938 - Flags: review+
(Assignee)

Comment 9

4 years ago
Created attachment 8618938 [details]
MozReview Request: pushlog: optimize retrieval of pushlog data (bug 1113458)
You need to log in before you can comment on or make changes to this bug.