1113523 - Recommended toolbar icon resolution differs from displayed resolution

Status: RESOLVED INCOMPLETE

(Add-on SDK Graveyard :: General, defect, P2)

Description

[marnick.leau]

Attachment: screenshot

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0
Build ID: 20141126041045

Steps to reproduce:

The SDK docs (such as https://developer.mozilla.org/en-US/Add-ons/SDK/Low-Level_APIs/ui_button_action#ActionButton%28options%29 ) recommend 18, 32, 36 and 64px as the resolution of your toolbar buttons.


Actual results:

Firefox displays the smallest icon at 16px instead of 18 when placed in the menu bar or navigation bar: http://puu.sh/dAPgd/c0067b22e5.png
(I have a theme enabled but I also checked it without any themes)


Expected results:

What is the correct set of resolutions we should supply our icons in? The linked page doesn't even stick to 1 set, it has a bunch of examples with different combinations. The most basic set accepted by the SDK is 16, 32 and 64. Icons of such a size shouldn't get resized to preserve their visual quality.

Comment 1

[Suman]

[Tracking Requested - why for this release]:

Comment 2

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Matteo, can you take a look at this? It looks like there is a custom theme involved, not high priority.

Comment 3

[marnick.leau]

(In reply to Jeff Griffiths (:canuckistani) from comment #2)
> Matteo, can you take a look at this? It looks like there is a custom theme
> involved, not high priority.

>(I have a theme enabled but I also checked it without any themes)

I checked it without a theme as well! It's the same in vanilla!

Comment 4

[Chris]

(In reply to Jeff Griffiths (:canuckistani) from comment #2)
> Matteo, can you take a look at this? It looks like there is a custom theme
> involved, not high priority.

This actually appears to be unrelated to the custom theme. It's particularly annoying with SVG toolbar icons on Windows when on high-DPI screens.

Comment 5

[Matteo Ferretti [:zer0] [:matteo]]

It seems to me that any buttons that is not a primary toolbar button is 16x16, where the primary are 18x18. See: https://dxr.mozilla.org/mozilla-central/source/browser/themes/osx/browser.css#579-591

I guess that was made for legacy reasons – old extensions that uses the previous 16x16 icon format.

We could either fix that on CSS, allowing the SDK button to use the same 18x18 format, or leave them at the 16x16, updating the docs and the value here: https://dxr.mozilla.org/mozilla-central/source/addon-sdk/source/lib/sdk/ui/button/view.js#82

I believe that currently it uses the 18x18 but it scale down to 16x16.

Comment 6

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1399562