Closed
Bug 1113530
Opened 9 years ago
Closed 9 years ago
Space key included in a keyword disables search engine
Categories
(Firefox :: Search, defect)
Tracking
()
People
(Reporter: phorea, Assigned: florian)
References
Details
Attachments
(1 file)
2.15 KB,
patch
|
Gijs
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Reproduced using Firefox 35 beta 5 and latest Nightly 37.0a1 2014-12-18 under all platforms. Steps to reproduce: 1. Open Preferences/Search in both in-content and window mode 2. Select a search engine from the table and double-click the keyword cell associated 3. Press "space" key / Write "a b" Expected results: "Space" key should not interfere with the keyword cells. Actual results: Each time the "space" key is pressed, the search engine gets disabled / enabled as the "space" character is used to disable/enable a search engine from the keyboard.
Assignee | ||
Comment 1•9 years ago
|
||
Assignee: nobody → florian
Updated•9 years ago
|
Attachment #8539222 -
Flags: review+
Assignee | ||
Comment 2•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/4169dc037086
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8539222 [details] [diff] [review] Patch Approval Request Comment [Feature/regressing bug #]: This fixes as mistake in my patch from bug 1106559 that landed for 35. [User impact if declined]: unfortunate edge case when typing the space space character while editing a keyword. [Describe test coverage new/current, TBPL]: tested locally both by me and the reviewer; QA will verify once this lands. [Risks and why]: low risk, trivial self-contained patch. [String/UUID change made/needed]: none.
Attachment #8539222 -
Flags: approval-mozilla-beta?
Attachment #8539222 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•9 years ago
|
Points: --- → 1
Flags: qe-verify+
Flags: firefox-backlog+
Updated•9 years ago
|
Status: NEW → ASSIGNED
Iteration: --- → 37.2
https://hg.mozilla.org/mozilla-central/rev/4169dc037086
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Updated•9 years ago
|
Updated•9 years ago
|
Attachment #8539222 -
Flags: approval-mozilla-beta?
Attachment #8539222 -
Flags: approval-mozilla-beta+
Attachment #8539222 -
Flags: approval-mozilla-aurora?
Attachment #8539222 -
Flags: approval-mozilla-aurora+
Comment 5•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/578cbaaa6c7c https://hg.mozilla.org/releases/mozilla-beta/rev/dd250cad6b4f
Comment 6•9 years ago
|
||
Verified fixed on: * Firefox 35.0b6 (20141222200458), * Aurora 36.0a2 (2014-12-23), * Nightly 37.0a1 (2014-12-23), using Ubuntu 12.04 LTS 32-bit, Windows 8.1 64-bit and Mac OS X 10.9.5.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•