Closed Bug 1113567 Opened 5 years ago Closed 5 years ago
No notification when trying to add the same keyword for two search engines
5 years ago
Depends on: 1106559
I forgot to add <stringbundle id="engineManagerBundle" src="chrome://browser/locale/engineManager.properties"/> to the in-content preferences xul file.
In comment 1 I thought the stringbundle had to go in in-content/preferences.xul, but putting it in search.xul actually works too. in-content/advanced.xul does it that way.
Assignee: nobody → florian
Status: NEW → ASSIGNED
Attachment #8540064 - Flags: review?(felipc)
[Tracking Requested - why for this release]: This is a bug of my patch from bug 1106559 that got uplifted to 35 and 36. I don't think we should care about this for 35 as the in-content preferences aren't enabled by default on beta/release, but it would be nice to fix this trivial error on 36.
Comment on attachment 8540064 [details] [diff] [review] Fix Approval Request Comment [Feature/regressing bug #]: new search preference UI (bug 1106559) [User impact if declined]: broken UI when adding 2 identical search keywords in the in-content preferences (currently enabled only on Nightly and Aurora) [Describe test coverage new/current, TBPL]: only tested locally; trivial fix [Risks and why]: very low, trivial fix. [String/UUID change made/needed]: none.
Attachment #8540064 - Flags: approval-mozilla-aurora?
Attachment #8540064 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Verified fixed on Windows 7 64bit, Windows 8 32bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using latest Nightly 37.0a1 (buildID: 20141230030214) and latest Aurora 36.0a2 (buildID: 20141230004009).
You need to log in before you can comment on or make changes to this bug.