1113619 - Abort on lifecycle event handler errors

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Abort ServiceWorker installation/activation if event handler errors

Comment 1

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: Abort on lifecycle event handler errors

Folded:
Handle install event listener errors and fail installation
Activate handler runtime errors should lead to activation failure.

Comment 2

[Andrea Marchesini [:baku]]

Comment on attachment 8539235 [details] [diff] [review]
Abort on lifecycle event handler errors

Review of attachment 8539235 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/ServiceWorkerManager.cpp
@@ +918,5 @@
>  
>    nsresult rv = target->DispatchDOMEvent(nullptr, event, nullptr, nullptr);
>  
>    nsCOMPtr<nsIGlobalObject> sgo = aWorkerPrivate->GlobalScope();
> +  WidgetEvent* internalEvent = event->GetInternalNSEvent();

can it be null?

@@ +1044,5 @@
>      nsRefPtr<Promise> waitUntilPromise;
>  
>      // FIXME(nsm): Install error handler for any listener errors.
>      nsresult rv = target->DispatchDOMEvent(nullptr, event, nullptr, nullptr);
> +    WidgetEvent* internalEvent = event->GetInternalNSEvent();

null?

Comment 3

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

From existing uses, it does not seem like this can ever be null.

Comment 4

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5f9d4b439044

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/5f9d4b439044