111368 - [W] MLK: Memory leak of 12 bytes from 1 block allocated in nsMsgComposeAndSend::AddCompFieldLocalAttachments(void)

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P2)

Description

[Navin Gupta]

Distribution of leaked blocks
    Allocation location
        new(UINT)      [new.cpp:23]
        nsMsgComposeAndSend::AddCompFieldLocalAttachments(void) 
[nsMsgSend.cpp:2103]
                        m_attachments[newLoc].mFileSpec->Delete(PR_FALSE);
                      delete (m_attachments[newLoc].mFileSpec);
                    }
         =>         m_attachments[newLoc].mFileSpec = new nsFileSpec( 
nsFileURL(url.get()) );
                    m_attachments[newLoc].mDeleteFile = PR_FALSE;
                    if (m_attachments[newLoc].mURL)
                    {
        nsMsgComposeAndSend::HackAttachments(nsMsgAttachmentData 
const*,nsMsgAttachedFile const*) [nsMsgSend.cpp:2342]
        nsMsgComposeAndSend::Init(nsIMsgIdentity *,nsMsgCompFields *,nsFileSpec 
*,int,int,int,nsIMsgDBHdr *,char const*,char const*,UINT,nsMsgAttachmentData 
const*,nsMsgAttachedFile const*,char const*) [nsMsgSend.cpp:2949]
        nsMsgComposeAndSend::CreateAndSendMessage(nsIEditorShell 
*,nsIMsgIdentity *,nsIMsgCompFields *,int,int,int,nsIMsgDBHdr *,char const*,char 
const*,UINT,nsMsgAttachmentData const*,nsMsgAttachedFile const*,void 
*,nsIDOMWindowInternal *,nsIMsgProgress *,nsIMs [nsMsgSend.cpp:3699]
        nsMsgCompose::_SendMsg(int,nsIMsgIdentity *,int) [nsMsgCompose.cpp:874]
        nsMsgCompose::SendMsg(int,nsIMsgIdentity *,nsIMsgProgress *) 
[nsMsgCompose.cpp:980]
        XPTC_InvokeByIndex [xptcinvoke.cpp:152]
        XPCWrappedNative::CallMethod(XPCCallContext&,CallMode::XPCWrappedNative) 
[xpcwrappednative.cpp:2009]
        XPC_WN_CallMethod(JSContext *,JSObject *,UINT,long *,long *) 
[xpcwrappednativejsops.cpp:1266]

Comment 1

[Navin Gupta]

Attachment: proposed fix

delete mFileSpec in the destructor.

Comment 2

[Navin Gupta]

cc bienvenu for review

Comment 3

[Navin Gupta]

david, need review here too, tia. 

Comment 4

[David :Bienvenu]

Comment on attachment 58822 [details] [diff] [review]
proposed fix

r=bienvenu, as long as no one else is holding a reference to the file spec

Comment 5

[Navin Gupta]

cc ducarroz for review.

Comment 6

[scottputterman]

JF, could you review this.

Comment 7

[Jean-Francois Ducarroz]

Comment on attachment 58822 [details] [diff] [review]
proposed fix

Seems to be the right thing to do. R=ducarroz. Bump David's review to
SR=bienvenu

Comment 8

[Jean-Francois Ducarroz]

Comment on attachment 58822 [details] [diff] [review]
proposed fix

Seems to be the right thing to do. R=ducarroz. Bump David's review to
SR=bienvenu

Comment 9

[Navin Gupta]

fixed

Comment 10

[[e-mail] (gone - use [e-mail] instead)]

Verified FIXED with the latest tip build running Purify on Win2k.