Closed Bug 1113695 Opened 5 years ago Closed 5 years ago
Critical Error thread safe
gfxCriticalError isn't thread safe and needs it because of the circular buffer. gfxDebug and gfxWarning may need it as well.
5 years ago
5 years ago
Assignee: nobody → milan
Don't think gfxDebug and gfxWarning need it.
Summary: Make gfxCriticalError, gfxDebug, gfxWarning thread safe → Make gfxCriticalError thread safe
Attachment #8539356 - Flags: review?(bas) → review+
Reusing try run that combined this with a more complicated patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8af8ab154d96 and https://treeherder.mozilla.org/#/jobs?repo=try&revision=ebbedb03bb15
(In reply to Milan Sreckovic [:milan] from comment #3) > Reusing try run that combined this with a more complicated patch: > https://treeherder.mozilla.org/#/jobs?repo=try&revision=8af8ab154d96 > and > https://treeherder.mozilla.org/#/jobs?repo=try&revision=ebbedb03bb15 Hi Milan, so i guess the try failures (and bustage on linux debug) like https://treeherder.mozilla.org/logviewer.html#?job_id=3804234&repo=try are more the failure of this other patch ?
Yes, the missing includes in the second patch. It's a slow day though, so I'll just do a full try and then we know. https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=a34fbe91b86f
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.