Closed Bug 1113706 Opened 6 years ago Closed 6 years ago
Marker to its own file
Olli suggested that TimelineMarker could be moved to its own header.
This moves TimelineMarker to a new header. It's a little more complicated than a straight move. Since the class was previously nested, I had to update various users. Also, I had to make a new .cpp file because TimelineMarker constructors need to call nsDocShell methods and so I had to break the dependency cycle. This is based on the patch in bug 1104213.
Comment on attachment 8539359 [details] [diff] [review] move TimelineMarker to a new header In the new files please use mozilla coding style - so 2 spaces for indentation. With that, r+
Attachment #8539359 - Flags: review?(bugs) → review+
I'm not sure why I thought 4 was the correct indentation. Fixed in this version.
Attachment #8539359 - Attachment is obsolete: true
Attachment #8540199 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Sorry for the spam. Moving bugs to Firefox :: Developer Tools: Performance Tools (Profiler/Timeline). dkl
Component: Developer Tools: Timeline → Developer Tools: Performance Tools (Profiler/Timeline)
You need to log in before you can comment on or make changes to this bug.