move TimelineMarker to its own file

RESOLVED FIXED in Firefox 37

Status

Product:
DevTools
Component:
Performance Tools (Profiler/Timeline)
Type:
defect
Status:
RESOLVED FIXED
Opened:
5 years ago
Updated:
Last year

People

(Reporter: tromey, Assigned: tromey)

Tracking

Version:
Trunk
Target:
Firefox 37
Platform:
x86_64
Linux
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

move TimelineMarker to a new header
15.90 KB, patch
Details | Diff | Splinter Review 
Olli suggested that TimelineMarker could be moved to its own header.
This moves TimelineMarker to a new header.

It's a little more complicated than a straight move.  Since the class
was previously nested, I had to update various users.  Also, I had to
make a new .cpp file because TimelineMarker constructors need to call
nsDocShell methods and so I had to break the dependency cycle.

This is based on the patch in bug 1104213.
Attachment #8539359 - Flags: review?(bugs)
Depends on: 1104213
Assignee: nobody → ttromey
Comment on attachment 8539359 [details] [diff] [review]
move TimelineMarker to a new header

In the new files please use mozilla coding style - so 2 spaces for indentation.
With that, r+
Attachment #8539359 - Flags: review?(bugs) → review+
I'm not sure why I thought 4 was the correct indentation.
Fixed in this version.
Attachment #8539359 - Attachment is obsolete: true
Rebased.
Attachment #8540199 - Attachment is obsolete: true
Keywords: checkin-needed
Blocks: 1117787
https://hg.mozilla.org/mozilla-central/rev/4793ea3d1a21
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Sorry for the spam. Moving bugs to Firefox :: Developer Tools: Performance Tools (Profiler/Timeline).

dkl
Component: Developer Tools: Timeline → Developer Tools: Performance Tools (Profiler/Timeline)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.