Closed
Bug 1113706
Opened 8 years ago
Closed 8 years ago
move TimelineMarker to its own file
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 37
People
(Reporter: tromey, Assigned: tromey)
References
Details
Attachments
(1 file, 2 obsolete files)
15.90 KB,
patch
|
Details | Diff | Splinter Review |
Olli suggested that TimelineMarker could be moved to its own header.
Assignee | ||
Comment 1•8 years ago
|
||
This moves TimelineMarker to a new header. It's a little more complicated than a straight move. Since the class was previously nested, I had to update various users. Also, I had to make a new .cpp file because TimelineMarker constructors need to call nsDocShell methods and so I had to break the dependency cycle. This is based on the patch in bug 1104213.
Assignee | ||
Updated•8 years ago
|
Attachment #8539359 -
Flags: review?(bugs)
Assignee | ||
Comment 2•8 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=7da9219d09be
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → ttromey
Comment 3•8 years ago
|
||
Comment on attachment 8539359 [details] [diff] [review] move TimelineMarker to a new header In the new files please use mozilla coding style - so 2 spaces for indentation. With that, r+
Attachment #8539359 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 4•8 years ago
|
||
I'm not sure why I thought 4 was the correct indentation. Fixed in this version.
Attachment #8539359 -
Attachment is obsolete: true
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/4793ea3d1a21
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/4793ea3d1a21
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Comment 8•7 years ago
|
||
Sorry for the spam. Moving bugs to Firefox :: Developer Tools: Performance Tools (Profiler/Timeline). dkl
Component: Developer Tools: Timeline → Developer Tools: Performance Tools (Profiler/Timeline)
Updated•4 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•