1113706 - move TimelineMarker to its own file

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Tom Tromey :tromey]

Olli suggested that TimelineMarker could be moved to its own header.

Comment 1

[Tom Tromey :tromey]

Attachment: move TimelineMarker to a new header

This moves TimelineMarker to a new header.

It's a little more complicated than a straight move.  Since the class
was previously nested, I had to update various users.  Also, I had to
make a new .cpp file because TimelineMarker constructors need to call
nsDocShell methods and so I had to break the dependency cycle.

This is based on the patch in bug 1104213.

Comment 2

[Tom Tromey :tromey]

https://tbpl.mozilla.org/?tree=Try&rev=7da9219d09be

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8539359 [details] [diff] [review]
move TimelineMarker to a new header

In the new files please use mozilla coding style - so 2 spaces for indentation.
With that, r+

Comment 4

[Tom Tromey :tromey]

Attachment: move TimelineMarker to a new header

I'm not sure why I thought 4 was the correct indentation.
Fixed in this version.

Comment 5

[Tom Tromey :tromey]

Attachment: move TimelineMarker to a new header

Rebased.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/fx-team/rev/4793ea3d1a21

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4793ea3d1a21

Comment 8

[David Lawrence [:dkl]]

Sorry for the spam. Moving bugs to Firefox :: Developer Tools: Performance Tools (Profiler/Timeline).

dkl