1113730 - mach build-backend --backend=VisualStudio fails with TypeError: _add_sources() takes exactly 3 arguments (4 given)

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Philip Chee]

+++ This bug was initially created as a clone of Bug #1109302 +++

I'm building from -inbound so I have 7ff7bcdb1271 in my tree.
Running mach build-backend --backend=VisualStudio causes the following error:

Philip@LENOVO-PC /c/t1/hg/comm-central
$ ./mozilla/mach build-backend --backend=VisualStudio
 0:07.75 c:\t1\hg\objdir-sm\_virtualenv\Scripts\python.exe c:\t1\hg\objdir-sm\config.status --backend=VisualStudio
Reticulating splines...
Traceback (most recent call last):
  File "c:\t1\hg\objdir-sm\config.status", line 954, in <module>
    config_status(**args)
  File "c:\t1\hg\comm-central\mozilla\python\mozbuild\mozbuild\config_status.py", line 148, in config_status
    summary = the_backend.consume(definitions)
  File "c:\t1\hg\comm-central\mozilla\python\mozbuild\mozbuild\backend\base.py", line 184, in consume
    self.consume_object(obj)
  File "c:\t1\hg\comm-central\mozilla\python\mozbuild\mozbuild\backend\visualstudio.py", line 104, in consume_object
    self._add_sources(self, reldir, obj)
TypeError: _add_sources() takes exactly 3 arguments (4 given)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: fix TypeError in the visualstudio backend

Doh, I'm not sure what I was thinking when I wrote that code.  Can you try out
this patch to see if it fixes things?

Comment 2

[Philip Chee]

Comment on attachment 8539369 [details] [diff] [review]
fix TypeError in the visualstudio backend

> $ ./mozilla/mach build-backend --backend=VisualStudio
>  0:00.39 c:\t1\hg\objdir-sm\_virtualenv\Scripts\python.exe c:\t1\hg\objdir-sm\config.status --backend=VisualStudio
> Reticulating splines...
> Traceback (most recent call last):
>   File "c:\t1\hg\objdir-sm\config.status", line 954, in <module>
>     config_status(**args)
>   File "c:\t1\hg\comm-central\mozilla\python\mozbuild\mozbuild\config_status.py", line 148, in config_status
>     summary = the_backend.consume(definitions)
>   File "c:\t1\hg\comm-central\mozilla\python\mozbuild\mozbuild\backend\base.py", line 184, in consume
>     self.consume_object(obj)
>   File "c:\t1\hg\comm-central\mozilla\python\mozbuild\mozbuild\backend\visualstudio.py", line 113, in consume_object
>     self._addr_sources(reldir, obj)
> AttributeError: 'VisualStudioBackend' object has no attribute '_addr_sources'

https://hg.mozilla.org/mozilla-central/rev/7ff7bcdb1271#l2.50

Comment 3

[Nathan Froyd [:froydnj]]

Attachment: fix TypeError in the visualstudio backend

Now with fewr misspellins.

Comment 4

[Philip Chee]

Comment on attachment 8539701 [details] [diff] [review]
fix TypeError in the visualstudio backend

> $ ./mozilla/mach build-backend --backend=VisualStudio
>  0:00.84 c:\t1\hg\objdir-sm\_virtualenv\Scripts\python.exe c:\t1\hg\objdir-sm\config.status --backend=VisualSt
> udio
> Reticulating splines...
> Finished reading 2888 moz.build files in 10.64s
> Processed into 8024 build config descriptors in 11.17s
> Backend executed in 13.37s
> Generated Visual Studio solution at c:/t1/hg/objdir-sm\msvc\mozilla.sln
> Total wall time: 36.36s; CPU time: 36.36s; Efficiency: 100%; Untracked: 1.17s

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/1e731b9bbd6a