1113754 - Intermittent testHomeBanner | Exception caught - java.lang.NullPointerException

Reporter

Description

•

8 years ago

10:25:17 INFO - SimpleTest START
10:25:17 INFO - TEST-START | testHomeBanner
10:25:17 INFO - TEST-PASS | testHomeBanner | Robocop tests need the test device screen to be powered on. -
10:25:17 INFO - TEST-PASS | testHomeBanner | Given message occurred for registered event: {"type":"Gecko:Ready"} - Gecko:Ready should equal Gecko:Ready
10:25:17 INFO - EventExpecter: no longer listening for Gecko:Ready
10:25:17 INFO - TEST-PASS | testHomeBanner | The HomePager is visible -
10:25:17 INFO - TEST-PASS | testHomeBanner | The HomeBanner is not visible -
10:25:17 INFO - TEST-PASS | testHomeBanner | url is not null - chrome://roboextender/content/robocop_home_banner.html#addMessage should not equal null
10:25:17 INFO - TEST-PASS | testHomeBanner | url is not null - chrome://roboextender/content/robocop_home_banner.html#addMessage should not equal null
10:25:17 INFO - TEST-PASS | testHomeBanner | The toolbar is not in the editing state -
10:25:17 INFO - TEST-PASS | testHomeBanner | Waiting for Toolbar to enter editing mode. -
10:25:17 INFO - TEST-PASS | testHomeBanner | Waiting for UrlEditText to be input method target. -
10:25:17 INFO - TEST-PASS | testHomeBanner | url is not null - chrome://roboextender/content/robocop_home_banner.html#addMessage should not equal null
10:25:17 INFO - TEST-PASS | testHomeBanner | The toolbar is in the editing state -
10:25:17 INFO - TEST-PASS | testHomeBanner | The UrlEditText is the input method target -
10:25:17 INFO - TEST-PASS | testHomeBanner | The toolbar is in the editing state -
10:25:17 INFO - TEST-PASS | testHomeBanner | initiatingAction is not null - org.mozilla.gecko.tests.components.ToolbarComponent$2@4142a9a0 should not equal null
10:25:17 INFO - 0 ERROR Exception caught during test! - java.lang.NullPointerException
10:25:17 INFO - at android.view.ViewGroup.findViewTraversal(ViewGroup.java:3070)
10:25:17 INFO - at android.widget.ListView.findViewTraversal(ListView.java:3435)
10:25:17 INFO - at android.view.View.findViewById(View.java:12247)
10:25:17 INFO - at android.view.ViewGroup.findViewTraversal(ViewGroup.java:3071)
10:25:17 INFO - at android.view.View.findViewById(View.java:12247)
10:25:17 INFO - at android.view.ViewGroup.findViewTraversal(ViewGroup.java:3071)
10:25:17 INFO - at android.view.View.findViewById(View.java:12247)
10:25:17 INFO - at android.view.ViewGroup.findViewTraversal(ViewGroup.java:3071)
10:25:17 INFO - at android.view.View.findViewById(View.java:12247)
10:25:17 INFO - at android.view.ViewGroup.findViewTraversal(ViewGroup.java:3071)
10:25:17 INFO - at android.view.View.findViewById(View.java:12247)
10:25:17 INFO - at android.view.ViewGroup.findViewTraversal(ViewGroup.java:3071)
10:25:17 INFO - at android.view.View.findViewById(View.java:12247)
10:25:17 INFO - at android.view.ViewGroup.findViewTraversal(ViewGroup.java:3071)
10:25:17 INFO - at android.view.View.findViewById(View.java:12247)
10:25:17 INFO - at android.view.ViewGroup.findViewTraversal(ViewGroup.java:3071)
10:25:17 INFO - at android.view.View.findViewById(View.java:12247)
10:25:17 INFO - at android.view.ViewGroup.findViewTraversal(ViewGroup.java:3071)
10:25:17 INFO - at android.view.View.findViewById(View.java:12247)
10:25:17 INFO - at android.view.Window.findViewById(Window.java:901)
10:25:17 INFO - at android.app.Activity.findViewById(Activity.java:1794)
10:25:17 INFO - at com.jayway.android.robotium.solo.Getter.getView(Getter.java:118)
10:25:17 INFO - at com.jayway.android.robotium.solo.Getter.getView(Getter.java:137)
10:25:17 INFO - at com.jayway.android.robotium.solo.Solo.getView(Solo.java:1982)
10:25:17 INFO - at com.jayway.android.robotium.solo.Solo.getView(Solo.java:1970)
10:25:17 INFO - at org.mozilla.gecko.tests.components.ToolbarComponent.getToolbarView(ToolbarComponent.java:93)
10:25:17 INFO - at org.mozilla.gecko.tests.components.ToolbarComponent.getUrlTitleText(ToolbarComponent.java:105)
10:25:17 INFO - at org.mozilla.gecko.tests.components.ToolbarComponent.getTitleHelper(ToolbarComponent.java:147)
10:25:17 INFO - at org.mozilla.gecko.tests.components.ToolbarComponent.getPotentiallyInconsistentTitle(ToolbarComponent.java:139)
10:25:17 INFO - at org.mozilla.gecko.tests.helpers.WaitHelper$ToolbarTitleTextChangeVerifier.storeState(WaitHelper.java:157)
10:25:17 INFO - at org.mozilla.gecko.tests.helpers.WaitHelper.waitForPageLoad(WaitHelper.java:84)
10:25:17 INFO - at org.mozilla.gecko.tests.components.ToolbarComponent.commitEditingMode(ToolbarComponent.java:174)
10:25:17 INFO - at org.mozilla.gecko.tests.helpers.NavigationHelper.enterAndLoadUrl(NavigationHelper.java:39)
10:25:17 INFO - at org.mozilla.gecko.tests.testHomeBanner.addBannerMessage(testHomeBanner.java:87)
10:25:17 INFO - at org.mozilla.gecko.tests.testHomeBanner.addBannerTest(testHomeBanner.java:39)
10:25:17 INFO - at org.mozilla.gecko.tests.testHomeBanner.testHomeBanner(testHomeBanner.java:20)
10:25:17 INFO - at java.lang.reflect.Method.invokeNative(Native Method)
10:25:17 INFO - at java.lang.reflect.Method.invoke(Method.java:511)
10:25:17 INFO - at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
10:25:17 INFO - at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
10:25:17 INFO - at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
10:25:17 INFO - at org.mozilla.gecko.tests.UITest.runTest(UITest.java:94)
10:25:17 INFO - at junit.framework.TestCase.runBare(TestCase.java:127)
10:25:17 INFO - at junit.framework.TestResult$1.protect(TestResult.java:106)
10:25:17 INFO - at junit.framework.TestResult.runProtected(TestResult.java:124)
10:25:17 INFO - at junit.framework.TestResult.run(TestResult.java:109)
10:25:17 INFO - at junit.framework.TestCase.run(TestCase.java:118)
10:25:17 INFO - at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:169)
10:25:17 INFO - at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:154)
10:25:17 INFO - at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:545)
10:25:17 INFO - at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1551)
10:25:17 WARNING - TEST-UNEXPECTED-FAIL | testHomeBanner | Exception caught - java.lang.NullPointerException
10:25:17 INFO - TEST-OK | testHomeBanner | took 12789ms
10:25:17 INFO - TEST-START | Shutdown
10:25:17 INFO - Passed: 14
10:25:17 INFO - Failed: 1
10:25:17 INFO - Todo: 0
10:25:17 INFO - SimpleTest FINISHED

Comment hidden (Legacy TBPL/Treeherder Robot)

submit_timestamp: 2014-12-19T10:55:33
log: https://treeherder.mozilla.org/ui/logviewer.html#?repo=mozilla-inbound&job_id=4816008
repository: mozilla-inbound
who: rvandermeulen[at]mozilla[dot]com
machine: panda-0541
buildname: Android 4.0 armv7 API 10+ mozilla-inbound opt test robocop-2
revision: c1ce930c56ca

12/19/2014 09:55:48: DEBUG: 19896 ?        S      0:00 python /builds/tools/buildfarm/mobile/../utils/retry.py --stderr-regexp ERROR 404: Not Found --fail-if-match wget -q -O/builds/panda-0539/buildbot.tac.new http://slavealloc.pvt.build.mozilla.org/gettac/panda-0539
TEST-UNEXPECTED-FAIL | testHomeBanner | Exception caught - java.lang.NullPointerException
12-19 10:25:14.226 E/GeckoLinker( 4125): /data/data/com.adobe.flashplayer/lib/libysshared.so: Text relocations are not supported
Return code: 1
12-19 10:26:36.539 E/GeckoLinker( 4385): /data/data/com.adobe.flashplayer/lib/libysshared.so: Text relocations are not supported

Geoff Brown [:gbrown]

Assignee

Comment 2

•

8 years ago

Attached image — Details

Geoff Brown [:gbrown]

Assignee

Comment 3

•

8 years ago

Possible regression from bug 1105792 or bug 1107002.

Geoff Brown [:gbrown]

Assignee

Updated

•

8 years ago

Updated

•

8 years ago

Updated

•

8 years ago

Comment 4

•

8 years ago

We've had success avoiding this type of failure with waitForView:

http://hg.mozilla.org/mozilla-central/annotate/67872ce17918/mobile/android/base/tests/components/AboutHomeComponent.java#l72

Geoff Brown [:gbrown]

Assignee

Comment 5

•

8 years ago

Attached patch waitForView before proceeding — Details — Splinter Review

Speculative, but worth a try...

Attachment #8542593 - Flags: review?(michael.l.comella)

Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]

Comment 6

•

8 years ago

Comment on attachment 8542593 [details] [diff] [review]
waitForView before proceeding

Review of attachment 8542593 [details] [diff] [review]:
-----------------------------------------------------------------

This is super strange:

10:25:17 INFO - at org.mozilla.gecko.tests.components.ToolbarComponent.commitEditingMode(ToolbarComponent.java:174)
10:25:17 INFO - at org.mozilla.gecko.tests.helpers.NavigationHelper.enterAndLoadUrl(NavigationHelper.java:39)

enterAndLoadUrl calls enterUrl [1] before commitEditingMode where enterUrl calls getUrlEditText [2] which successfully calls getToolbarView [3], which is our crashing friend. So somewhere after entering a url and hitting enter, the toolbar view disappears from the hierarchy! How strange!

Under the assumption that it should return, I'm okay with this fix. However, there are two possibilities I can think of:
  1) Robocop is accessing the views at a time when the hierarchy is incomplete or inaccessible (e.g. maybe layout?) and so this is probably the only fix
  2) We're doing some excessive work during page load that forces the toolbar to hide itself and this solution is covering up our inefficiencies.

If #2, I suppose there are more intuitive ways to do performance testing in UI so we should focus on that route. Thus, this wfm.

[1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/tests/helpers/NavigationHelper.java?rev=9eb089d7c2b9#40
[2]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/tests/components/ToolbarComponent.java?rev=51ca6ef95772#201
[3]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/tests/components/ToolbarComponent.java?rev=51ca6ef95772#201k

Attachment #8542593 - Flags: review?(michael.l.comella) → review+

Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]

Comment 7

•

8 years ago

Do you have a try run?

Also, I wonder if we shouldn't do this for all of our get*View methods, given comment 6. I'll add some notes to bug 972042.

Flags: needinfo?(gbrown)

Comment 8

•

8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc12d403667f

Thanks Michael. waitForView before every getView seems like overkill, but I certainly think there are additional opportunities to use this technique.

Flags: needinfo?(gbrown)

Geoff Brown [:gbrown]

Assignee

Comment 9

•

8 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/4912606fb9c7

Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)

Comment 10

•

8 years ago

https://hg.mozilla.org/mozilla-central/rev/4912606fb9c7

Status: NEW → RESOLVED

Closed: 8 years ago

Resolution: --- → FIXED

Target Milestone: --- → Firefox 37

Ryan VanderMeulen [:RyanVM]

Reporter

Updated

•

8 years ago

status-firefox35: --- → unaffected

status-firefox36: --- → unaffected

status-firefox37: --- → fixed

status-firefox-esr31: --- → unaffected

Comment hidden (Legacy TBPL/Treeherder Robot)

submit_timestamp: 2015-01-06T22:48:14
log: https://treeherder.mozilla.org/ui/logviewer.html#?repo=b2g-inbound&job_id=1107430
repository: b2g-inbound
who: philringnalda[at]gmail[dot]com
machine: tst-linux64-spot-094
buildname: Android armv7 API 9 b2g-inbound opt test robocop-2
revision: 4baccd81ced8

TEST-UNEXPECTED-FAIL | testHomeBanner | Exception caught - java.lang.NullPointerException

Comment hidden (Legacy TBPL/Treeherder Robot)

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=5833086
repository: mozilla-inbound
start_time: 2015-01-23T09:51:41
who: rvandermeulen[at]mozilla[dot]com
machine: tst-linux64-spot-802
buildname: Android armv7 API 9 mozilla-inbound opt test robocop-2
revision: 6940eaeea289

TEST-UNEXPECTED-FAIL | testHomeBanner | Exception caught - java.lang.NullPointerException

Comment hidden (Legacy TBPL/Treeherder Robot)

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=1846815
repository: fx-team
start_time: 2015-01-30T10:09:02
who: rvandermeulen[at]mozilla[dot]com
machine: tst-linux64-spot-935
buildname: Android armv7 API 9 fx-team opt test robocop-2
revision: 33e36676db90

TEST-UNEXPECTED-FAIL | testHomeBanner | Exception caught - java.lang.NullPointerException

Comment hidden (Legacy TBPL/Treeherder Robot)

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=6379943
repository: mozilla-inbound
start_time: 2015-02-07T02:39:41
who: philringnalda[at]gmail[dot]com
machine: tst-linux64-spot-658
buildname: Android armv7 API 9 mozilla-inbound opt test robocop-2
revision: 22f4338d2e18

TEST-UNEXPECTED-FAIL | testHomeBanner | Exception caught - java.lang.NullPointerException

Comment hidden (Legacy TBPL/Treeherder Robot)

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=2003527
repository: fx-team
start_time: 2015-02-16T02:34:43
who: tomcat[at]mozilla[dot]com
machine: tst-linux64-spot-407
buildname: Android armv7 API 9 fx-team opt test robocop-2
revision: f0048ba13213

TEST-UNEXPECTED-FAIL | testHomeBanner | Exception caught - java.lang.NullPointerException

Nobody; OK to take it and work on it

Updated

•

2 years ago

Product: Firefox for Android → Firefox for Android Graveyard

screenshot from comment 0 8 years ago Geoff Brown [:gbrown] 194.92 KB, image/jpeg		Details
waitForView before proceeding 8 years ago Geoff Brown [:gbrown] 1006 bytes, patch	mcomella : review+	Details \| Diff \| Splinter Review

Bugzilla

Quick Search

Intermittent testHomeBanner | Exception caught - java.lang.NullPointerException

Categories

(Firefox for Android Graveyard :: General, defect)

Tracking

(firefox35 unaffected, firefox36 unaffected, firefox37 fixed, firefox-esr31 unaffected)

People

(Reporter: RyanVM, Assigned: gbrown)

References

Details

(Keywords: crash, intermittent-failure)

Crash Data

Security

(public)

User Story

Attachments

(2 files)

Description

Comment 1

Comment 2

Comment 3

Updated

Updated

Updated

Comment 4

Comment 5

Comment 6

Comment 7

Comment 8

Comment 9

Comment 10

Updated

Comment 11

Comment 12

Comment 13

Comment 14

Comment 15

Updated