Add videos with counters to gaia-ui tests

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: martijn.martijn, Assigned: martijn.martijn)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
This came up while we were discussing bug 1113219.
The current videos we are using for testing, aren't really descriptive.
When a screenshot is made when one of the video tests are failing, the video doesn't make clear at what point in time it is (at least not very clearly).

In that sense, it would be better to have videos that have a counter in them or something like that.

On MacOSX, it is quite easy to make a video of parts of the screen, so it should be fairly easy to make videos like that.
(Assignee)

Comment 1

4 years ago
I have an ogg video here: http://people.mozilla.org/~mwargers/tests/videos/counter.ogg
I'm apparently really clumsy with making videos, but I think this is good enough for the purpose.
If you think this is good enough, I can make the different formats of this video and replace the other ones that we use for testing with this one.
Flags: needinfo?(gmealer)
(Assignee)

Updated

4 years ago
QA Whiteboard: [fxosqa-auto-s7][fxosqa-auto-points=4]
(In reply to Martijn Wargers [:mwargers] (QA) from comment #1)
> I have an ogg video here:
> http://people.mozilla.org/~mwargers/tests/videos/counter.ogg
> I'm apparently really clumsy with making videos, but I think this is good
> enough for the purpose.
> If you think this is good enough, I can make the different formats of this
> video and replace the other ones that we use for testing with this one.

Looks good to me. We should make sure that tests using the videos aren't counting on specific lengths or content, though.
Flags: needinfo?(gmealer)
Also, depending on who "owns" the videos, we might want to add these as new ones and not replace the old ones (we can port our tests over to use the new files). That way, if other suites are depending on them they won't get compromised.
(Assignee)

Updated

4 years ago
Blocks: 1159352
(Assignee)

Comment 4

4 years ago
I put the various formats here: http://people.mozilla.org/~mwargers/tests/videos/counter/
I used this online tool to convert to the various formats: http://video.online-convert.com/
VLC totally failed on converting for me.
(Assignee)

Comment 5

4 years ago
The files are bigger than what we're currently using, but I don't think it should be an issue (although it increases the time to push those files to device).
Created attachment 8602145 [details] [review]
[gaia] mwargers:1113762 > mozilla-b2g:master
(Assignee)

Comment 7

4 years ago
Comment on attachment 8602145 [details] [review]
[gaia] mwargers:1113762 > mozilla-b2g:master

I checked at least for mp4 and webm that the codec (audio and video) is the same as used for the original video file. So it seems that that online video tool was correctly converting the file.
Attachment #8602145 - Flags: review?(jlorenzo)
Attachment #8602145 - Flags: review?(gmealer)
Comment on attachment 8602145 [details] [review]
[gaia] mwargers:1113762 > mozilla-b2g:master

Each of the 5 videos is not that big:
> 680K	VID_counter.3gp
> 788K	VID_counter.mp4
> 936K	VID_counter.ogg
> 1.4M	VID_counter.ogv
> 1.4M	VID_counter.webm

All of them last 20 seconds and render both video and sound. They can be fast forwarded. I don't see any problem!
Attachment #8602145 - Flags: review?(jlorenzo) → review+
Comment on attachment 8602145 [details] [review]
[gaia] mwargers:1113762 > mozilla-b2g:master

LGTM! Nice improvement.
Attachment #8602145 - Flags: review?(gmealer) → review+
(Assignee)

Comment 10

4 years ago
https://github.com/mozilla-b2g/gaia/commit/6bb1aec1ec65febd4158b8d9ef8024a49bcdf560
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Blocks: 1163683
You need to log in before you can comment on or make changes to this bug.