1113786 - 'Find in page' search toolbar doesn't respect privacy in private tabs/mode, keeps search term after closing private tab

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox for Android Nightly build today with the patch from bug 1112230 on Try: https://tbpl.mozilla.org/?tree=Try&rev=d320d70c5fca
Android 4.1.2 stock on Nexus S

The 'Find in page' search toolbar doesn't respect the privacy but keeps the search term used on a private tab after closing it.

Steps to reproduce:
1. Launch Firefox for Android.
2. Open a new private tab, e.g. a news site.
3. Search for a common word, e.g. "the".
4. Open the tab list and close the private tab by swiping.
5. Load a page in the normal tab and open again the 'Find in page' toolbar.

Actual result:
Search term from 3. shown

Expected result:
Search bar empty

Comment 1

[Mark Capella [:capella]]

Attachment: bug1113786.diff

Persisting the string across page searches is convenient, and I'm pretty sure we don't want to simply clear the field each time we open the FIPB.

Probably the best solution we might offer is to clear it on FIPB close, if the user initiated or otherwise searched while in a private tab.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

How strongly would people care if we cleared the Find text box on every "close"? That would be my preference. It might seem a bit conservative, but it handles all edge cases.

Comment 3

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

It seems to me like the "Find in page" bar should close when the user closes/moves away from that tab. Particularly because one cannot trigger "Find in page" in about:home anyways (what you see when you start a new tab).

Specifically for this bug though... I agree, in private mode, it should definitely clear and close.

Hope that helps!

Comment 4

[Mark Capella [:capella]]

Attachment: bug1113786.diff

Simple is better wfm

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8546926 [details] [diff] [review]
bug1113786.diff

LGTM. I'll file a bug about closing the FindInPageBar when switching tabs.

Comment 6

[Mark Capella [:capella]]

try
https://tbpl.mozilla.org/?tree=Try&rev=ad0189c6bfab

Comment 7

[Mark Capella [:capella]]

(yawn)
https://hg.mozilla.org/integration/fx-team/rev/d606591cf149

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d606591cf149