1113828 - Don't print anything when passing an invalid draw target to CreateDrawTargetForData

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Attachment: patch

Returning null is an expected property of this function and gfxPlatform::CreateDrawTargetForData() uses this. Removing this message prevents us from printing a bunch of messages during the normal usage of a debug build.

Comment 1

[Bas Schouten (:bas.schouten)]

Comment on attachment 8539507 [details] [diff] [review]
patch

Review of attachment 8539507 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/opengl/GrallocTextureHost.cpp
@@ -96,4 @@
>    }
>  }
>  
> -GrallocTextureSourceOGL::GrallocTextureSourceOGL(CompositorOGL* aCompositor,

What's this doing in here?

Comment 2

[Bas Schouten (:bas.schouten)]

Comment on attachment 8539507 [details] [diff] [review]
patch

Review of attachment 8539507 [details] [diff] [review]:
-----------------------------------------------------------------

Don't forget to remove that bad hunk...

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b72055695f3d

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b72055695f3d