1113851 - [Settings] Change time format to 24-hour, write gaia-ui test

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Martijn Wargers (dead)]

This bug handles the case of writing a gaia-ui test for: https://moztrap.mozilla.org/manage/case/14358/


    Launch settings

    Tap "Date & Time"

    Change Time Format from "12-hour" to "24-hour"
        The time in header should become 24-hour.

    Lock the test phone by pressing the "Power/Sleep" button.

    press power button again

    The time in lockscreen display as 24-hour

Comment 1

[Florin Strugariu [:Bebe]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27193

Comment 2

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

I have some concerns before reviewing, particularly around the side-effect of setting the time to 10pm, which I put in the github comments.

Comment 3

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Plussing the nom flag since we're working on this.

Comment 4

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

(In reply to Geo Mealer [:geo] from comment #2)
> I have some concerns before reviewing, particularly around the side-effect
> of setting the time to 10pm, which I put in the github comments.

Per our in-person conversation, sounds like the time will always be reverted to current by the known state reset, so there's no change of fouling the other tests re: my concern.

I would like to make sure that either that's true if we eliminate the --restart command line option, OR that our test base in general always assumes that option will be there.

Once you confirm we're safe on that, this'll be an r+ for me.

Also, I'm resetting the flag. After short discussion today, think we decided that ? is fine (if redundant) and that we can handle excluding from triage another way. Please set in-qa-testsuite+ again once the test is r+'d and merged.

Comment 5

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Comment on attachment 8545175 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27193

r+, but I'm still a little concerned about the question above. I thought the standard was tests cleaned up after themselves. If I'm wrong about that, the code's fine.

Comment 6

[Robert Chira [:RobertC]]

Comment on attachment 8545175 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27193

Merged in master:
https://github.com/mozilla-b2g/gaia/commit/36ab9ef82d57c67295308719859fc622a76020d5