Closed Bug 1113867 Opened 9 years ago Closed 7 years ago

Implement an updated design for devedition dark theme tab colors

Categories

(Firefox :: Theme, defect)

defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: bgrins, Unassigned)

References

(Depends on 1 open bug)

Details

(Whiteboard: [devedition-polish][devtools-ux])

We realized in Bug 1112715 that the specified colors for tabs in dark and light theme weren't being applied due to specificity.  Instead it is using the #TabsToolbar color for normal and hover states.  Went ahead and cleaned up the CSS there, but we should revisit with designs for the different tab states.
Here are the text colors being used now:

Normal tab color: --chrome-color: #F5F7FA.
Hover tab color: --chrome-color: #F5F7FA;
Selected tab color: --tab-selection-color: #F5F7FA

In particular, there isn't an obvious text color difference when hovering the tab.  It'd be great to have a design pass through of the different states.  Stephen, can you help?
Flags: needinfo?(shorlander)
Whiteboard: [devedition-polish]
Note that on OSX, there is an opacity of .7 on tab text for unselected tabs: http://dxr.mozilla.org/mozilla-central/source/browser/themes/osx/browser.css#3055.  We will need to consider that when implementing the designs and either override that rule or just be aware that it will look different in OSX.
Whiteboard: [devedition-polish] → [devedition-polish][devtools-ux]
Photon refresh should fix this.
Flags: needinfo?(shorlander)
See Also: → photon-tabs
Depends on: photon-tabs
See Also: photon-tabs
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.