1113955 - Still compile regexp jit code when we can string match

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Hannes Verschore [:h4writer]]

Currently we disable compiling the regexp jit code of a RegExp literal when we notice it is a flat string match (no special characters). This is good and faster for C++ to C++ code, but when we are in ionmonkey we prefer doing JIT to JIT calls. So we should use the regexp jit trampoline. (Instead of calling from JIT to C++).

Nostringmatch: Remove use of string matching for RegExp literal if possible
Alwayscompile: Still compile regexp jit code when we can use string matching.

Octane-regexp:
- score before:  2800
- Nostringmatch: 2600
- Alwayscompile: 3000

Comment 1

[Hannes Verschore [:h4writer]]

Attachment: Patch

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8539657 [details] [diff] [review]
Patch

Review of attachment 8539657 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

Comment 3

[Hannes Verschore [:h4writer]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6a3b650204e7

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6a3b650204e7