Still compile regexp jit code when we can string match

RESOLVED FIXED in mozilla37

Status

()

Core
JavaScript Engine: JIT
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: h4writer, Assigned: h4writer)

Tracking

(Blocks: 1 bug)

unspecified
mozilla37
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Currently we disable compiling the regexp jit code of a RegExp literal when we notice it is a flat string match (no special characters). This is good and faster for C++ to C++ code, but when we are in ionmonkey we prefer doing JIT to JIT calls. So we should use the regexp jit trampoline. (Instead of calling from JIT to C++).

Nostringmatch: Remove use of string matching for RegExp literal if possible
Alwayscompile: Still compile regexp jit code when we can use string matching.

Octane-regexp:
- score before:  2800
- Nostringmatch: 2600
- Alwayscompile: 3000
(Assignee)

Updated

3 years ago
Blocks: 806646
(Assignee)

Comment 1

3 years ago
Created attachment 8539657 [details] [diff] [review]
Patch
Assignee: nobody → hv1989
Attachment #8539657 - Flags: review?(jdemooij)
Comment on attachment 8539657 [details] [diff] [review]
Patch

Review of attachment 8539657 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.
Attachment #8539657 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/6a3b650204e7
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.