Closed
Bug 1113955
Opened 11 years ago
Closed 11 years ago
Still compile regexp jit code when we can string match
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: h4writer, Assigned: h4writer)
References
Details
Attachments
(1 file)
|
2.17 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
Currently we disable compiling the regexp jit code of a RegExp literal when we notice it is a flat string match (no special characters). This is good and faster for C++ to C++ code, but when we are in ionmonkey we prefer doing JIT to JIT calls. So we should use the regexp jit trampoline. (Instead of calling from JIT to C++).
Nostringmatch: Remove use of string matching for RegExp literal if possible
Alwayscompile: Still compile regexp jit code when we can use string matching.
Octane-regexp:
- score before: 2800
- Nostringmatch: 2600
- Alwayscompile: 3000
|
Assignee | |
Comment 1•11 years ago
|
||
Assignee: nobody → hv1989
Attachment #8539657 -
Flags: review?(jdemooij)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8539657 [details] [diff] [review]
Patch
Review of attachment 8539657 [details] [diff] [review]:
-----------------------------------------------------------------
Nice.
Attachment #8539657 -
Flags: review?(jdemooij) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•