1114030 - Current page isn't highlighted in AwesomeBar

Status: NEW

(Firefox :: Address Bar, enhancement, P5)

Description

[Paul [pwd]]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:37.0) Gecko/20100101 Firefox/37.0
Build ID: 20141215131251

Steps to reproduce:

Click down arrow on AwesomeBar and go to a top site
Click down arrow on AwesomeBar


Actual results:

Nothing


Expected results:

Current site should be highlighted until a user starts typing

Comment 1

[Marco Bonardo [:mak]]

could you please better clarify what this bug is about, I don't understand.

Comment 2

[Paul [pwd]]

(In reply to Marco Bonardo [::mak] (needinfo? me) from comment #1)
> could you please better clarify what this bug is about, I don't understand.

The location bar (referred to previously as the AwesomeBar), you see a down arrow, upon clicking that you reveal the top sites (as ordered via frecency (frequency + recency IIRC), if you're at a location within that list, it's supposed to be highlighted up until the point you start typing or move the arrow to select another site.

I hope that better explains it?

Comment 3

[Marco Bonardo [:mak]]

After you open the dropdown, how do you select from it, with the keyword?

Then what do you do, just start typing? I don't understand cause I cannot reproduce anything strange there... I'm sorry but I need fine grained steps to reach your unexpected result.

Comment 4

[Paul [pwd]]

(In reply to Marco Bonardo [::mak] (needinfo? me) from comment #3)
> After you open the dropdown, how do you select from it, with the keyword?
By left-clicking with the mouse

> Then what do you do, just start typing? I don't understand cause I cannot
> reproduce anything strange there... I'm sorry but I need fine grained steps
> to reach your unexpected result.

1. Move mouse to arrow in location
2. Left click arrow
3. Left click the top row
4. Wait for the page to load
5. Left click the arrow again

Expected Result: Current site should be highlighted[1][2].

Actual Result: The browser seems bewildered as to where you are only displaying the URL above the list.








Please Ignore This Until You Get What I'm Referring To As This Will Only Further Confuse Things:
[1] Given that the site is already loaded, the row should be a/ highlighted and b/ upon clicking should do nothing
[2] This was actually how it used to behave.

Comment 5

[Paul [pwd]]

> Expected Result: Current site should be highlighted[1][2].

* Expected Result: Current site (i.e. the row previously clicked)

Comment 6

[Marco Bonardo [:mak]]

ok, I see what you mean, last comment was useful.

We could definitely handle this edge case better, but doesn't look like a top priority issue for now. Confirming as an enhancement.

When you said that it used to work like that, I think it was when UnifiedComplete feature was enabled. it will be re-enabled in (short) future, we are currently working on some regressions (see bug 995091)

Comment 7

[Paul [pwd]]

It used to work before the unified complete madness. I'm not sure if Unified Complete broke it or not but it's certainly not working as per it was since Firefox 4, hence filing as a bug.

Comment 8

[Paul [pwd]]

Oops sorry, confused this bug with with the other AwesomeBar bug I filed today. Though this was certainly working for a very long time too. Hopefully UnifiedComplete fixed the both of them at once.