1114046 - [sms] non-whitespace carrier separator in recipient remove dialog shown even if no carrier info available

Status: RESOLVED DUPLICATE of bug 1112539

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: screenshot of issue

B2G 2.2 20141219160206 on Flame (v188 base image)

Steps to reproduce:
1. Change the device language to German ("Deutsch") or Lithuanian ("Lietuviu").
2. Open SMS app.
3. Add a contact without carrier information as recipient.
4. Tap on the contact to remove it.

Actual result:
The contact details show a third line only containing the separator for phone number and carrier:

Expected result:
No third line.

The contact details creation:
https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/js/recipients.js#L1078
=>
https://github.com/mozilla-b2g/gaia/blob/7bf9b6a6c262a8ff656a8d415c9f6cfef5c23e54/apps/sms/js/shared_components.js#L19
=>
https://github.com/mozilla-b2g/gaia/blob/3a8e75217255a281c92991994674a07ae6c48650/apps/sms/index.html#L553
=>
http://mxr.mozilla.org/gaia/source/shared/js/l10n.js#900

So there should be a check if the carrier information is empty or an empty string and if that is true, the separator shouldn't be used.

Comment 1

[Oleg Zasypkin [:azasypkin]]

Thanks for reporting! Will fix it in bug 1112539 very soon.