Don't include Windows headers inside a namespace.

RESOLVED FIXED in mozilla37

Status

()

Toolkit
Downloads API
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

unspecified
mozilla37
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8539708 [details] [diff] [review]
patch.diff

The comment about mozIStorageError seems outdated. It builds fine then included on top of the file:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4f98e127a706

Those headers are included in namespace now. This causes problems with mingw builds.
Attachment #8539708 - Flags: review?(paolo.mozmail)

Updated

3 years ago
Attachment #8539708 - Flags: review?(paolo.mozmail) → review+
(Assignee)

Comment 1

3 years ago
Thanks for quick review.

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec8e54c0352e
https://hg.mozilla.org/mozilla-central/rev/ec8e54c0352e
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.