Closed Bug 1114052 Opened 6 years ago Closed 6 years ago

Don't include Windows headers inside a namespace.

Categories

(Toolkit :: Downloads API, defect)

Product:
Toolkit
Component:
Downloads API
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla37

People

(Reporter: jacek, Assigned: jacek)

Details

Attachments

(1 file)

patch.diff
1.50 KB, patch
Paolo
: review+
Details | Diff | Splinter Review
Attached patch patch.diff — — Splinter Review 
The comment about mozIStorageError seems outdated. It builds fine then included on top of the file:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4f98e127a706

Those headers are included in namespace now. This causes problems with mingw builds.
Attachment #8539708 - Flags: review?(paolo.mozmail)
Attachment #8539708 - Flags: review?(paolo.mozmail) → review+
https://hg.mozilla.org/mozilla-central/rev/ec8e54c0352e
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.