Closed
Bug 1114052
Opened 10 years ago
Closed 10 years ago
Don't include Windows headers inside a namespace.
Categories
(Toolkit :: Downloads API, defect)
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: jacek, Assigned: jacek)
Details
Attachments
(1 file)
|
1.50 KB,
patch
|
Paolo
:
review+
|
Details | Diff | Splinter Review |
The comment about mozIStorageError seems outdated. It builds fine then included on top of the file:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4f98e127a706
Those headers are included in namespace now. This causes problems with mingw builds.
Attachment #8539708 -
Flags: review?(paolo.mozmail)
|
||
Updated•10 years ago
|
Attachment #8539708 -
Flags: review?(paolo.mozmail) → review+
|
Assignee | |
Comment 1•10 years ago
|
||
Thanks for quick review.
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec8e54c0352e
|
||
Comment 2•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•