Closed
Bug 1114064
Opened 10 years ago
Closed 9 years ago
Make it possible to have an MCallDOMNative for a jitinfo which is AliasNone
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
3.81 KB,
patch
|
efaust
:
review+
philor
:
checkin+
|
Details | Diff | Splinter Review |
Right now the JIT assumes that the jitinfo for a DOM method (as opposed to getter) cannot be AliasNone. I'd like to actually create some AliasNone methods, so this assumption needs to be rectified.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8539714 -
Flags: review?(efaustbmo)
Comment 2•10 years ago
|
||
Comment on attachment 8539714 [details] [diff] [review] Support AliasNone DOM methods in ion compilation Review of attachment 8539714 [details] [diff] [review]: ----------------------------------------------------------------- I was just thinking about these and noting that we would have to clean this up. r=me
Attachment #8539714 -
Flags: review?(efaustbmo) → review+
Comment 3•10 years ago
|
||
Out of curiosity, what methods are these?
Comment 4•10 years ago
|
||
(In reply to Jeff Walden [:Waldo] (remove +bmo to email) from comment #3) > Out of curiosity, what methods are these? This should be MCallDOMNative::getAliasSet(). We have a system by which the DOM bindings can specify the alias sets of various functions via JitInfo, and we are expanding that system.
Comment 5•10 years ago
|
||
No, what *DOM* methods. :-)
Comment 6•10 years ago
|
||
Oh. I think mostly performance.now() is one that aliases nothing that we want to allow people to hoist around.
Assignee | ||
Comment 7•10 years ago
|
||
Yeah, for now performance.now(). But in general, methods that guarantee that all observable behavior is async might fall into this bucket, and people are adding more async methods to the platform.
Assignee | ||
Comment 8•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/039ae5be340a
Target Milestone: --- → mozilla37
Comment 9•9 years ago
|
||
The fun never stops - with bug 1112934 backed out, ggc started asserting like https://treeherder.mozilla.org/logviewer.html#?job_id=5051574&repo=mozilla-inbound so I backed this out in https://hg.mozilla.org/integration/mozilla-inbound/rev/811c950c8df6
Depends on: 1112934
Comment 10•9 years ago
|
||
Comment on attachment 8539714 [details] [diff] [review] Support AliasNone DOM methods in ion compilation Relanded in https://hg.mozilla.org/integration/mozilla-inbound/rev/206763e2c234
Attachment #8539714 -
Flags: checkin+
Comment 11•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/206763e2c234
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•