1114267 - Enforce that MOZ_ONLY_USED_TO_AVOID_STATIC_CONSTRUCTORS classes can only have trivial ctors and dtors

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Comment 1

[(no longer active)]

Attachment: Part 1: Add an analysis to force some classes to have trivial ctors and dtors

Comment 2

[(no longer active)]

Attachment: Part 2: Add MOZ_TRIVIAL_CTOR_DTOR to MOZ_ONLY_USED_TO_AVOID_STATIC_CONSTRUCTORS in non-debug builds

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8539749 [details] [diff] [review]
Part 1: Add an analysis to force some classes to have trivial ctors and dtors

Review of attachment 8539749 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/clang-plugin/tests/TestTrivialCtorDtor.cpp
@@ +9,5 @@
> +  BadUserDefinedCtor() {}
> +};
> +
> +struct MOZ_TRIVIAL_CTOR_DTOR BadUserDefinedDtor { // expected-error {{class 'BadUserDefinedDtor' must have trivial constructors and destructors}}
> +  BadUserDefinedDtor() {}

~BadUserDefinedDtor

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6992f8b890ff
https://hg.mozilla.org/mozilla-central/rev/682c3ff54fae