Closed Bug 1114328 Opened 8 years ago Closed 8 years ago

Remove some useless variables

Categories

(MailNews Core :: Backend, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 37.0

People

(Reporter: Sylvestre, Assigned: Sylvestre)

Details

Attachments

(1 file)

clang finds some useless variables. The attached patch removes some of them.

Try running:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=e8fc9faad7d1
Attachment #8539792 - Flags: review?(standard8)
Attachment #8539792 - Flags: review?(standard8) → review?(Pidgeot18)
Assignee: nobody → sledru
Comment on attachment 8539792 [details] [diff] [review]
delete-useless-variables.diff

Review of attachment 8539792 [details] [diff] [review]:
-----------------------------------------------------------------

The nsMsgSend.cpp portions fail to apply, and I suspect you're going to do a bitrot race with bug 1118027 if you try to update them. Otherwise, it looks good.
Attachment #8539792 - Flags: review?(Pidgeot18) → review+
Comment on attachment 8539792 [details] [diff] [review]
delete-useless-variables.diff

merged: 
https://hg.mozilla.org/comm-central/rev/33de262ca789

I took the liberty to a=jcranmer
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.