Closed Bug 1114363 Opened 5 years ago Closed 5 years ago

Mac default: Rely on '-moz-window-dragging: drag;' instead of suite's toolbar.xml bindings

Categories

(SeaMonkey :: Themes, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.34

People

(Reporter: stefanh, Assigned: stefanh)

Details

Attachments

(1 file)

Bug 944836 introduced a new css property: -moz-window-dragging: drag|nodrag|inherit. Toolkit (mac) theme files now use "-moz-window-dragging: drag;" instead of bindings.

This means that we can do some clean-up of our css.
Attached patch 1114363.1.diffSplinter Review
I removed one binding that was only used in Mac default. The grippytoolbar-drag binding seems to be used by win/nix.
Assignee: nobody → stefanh
Status: NEW → ASSIGNED
Attachment #8539825 - Flags: review?(mnyromyr)
Comment on attachment 8539825 [details] [diff] [review]
1114363.1.diff

Happy new year, Stefan. :-)

Looks good.

(And without this patch, dragging a (lightweight-themed) window by it's titlebar is even impossible on Mac.)
Attachment #8539825 - Flags: review?(mnyromyr) → review+
Happy New Year Karsten and thanks :-)

https://hg.mozilla.org/comm-central/rev/f5d850dad827
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.34
(In reply to Stefan [:stefanh] from comment #0)
> Bug 944836 introduced a new css property: -moz-window-dragging:
> drag|nodrag|inherit. Toolkit (mac) theme files now use
> "-moz-window-dragging: drag;" instead of bindings.
> 
> This means that we can do some clean-up of our css.

FYI Bug 944836 was backed out for Firefox 35.0.1
Also see Firefox Bug 1122942 - Can't drag or move Firefox window when a third-party theme is installed
Flags: needinfo?(stefanh)
Yeah, I know. If there's a 35.01 (and we're doing the same), we should follow-up this on comm-release. Care to file a bug?

Bug 1122942 needs to be followed-up too (on relevant branches).
Flags: needinfo?(stefanh)
Actually, this patch is in c-aurora, not c-release/beta.
You need to log in before you can comment on or make changes to this bug.