Closed
Bug 1114368
Opened 11 years ago
Closed 11 years ago
Use GCC builtins in MathAlgorithms.h on mingw.
Categories
(Core :: MFBT, defect)
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: jacek, Assigned: jacek)
Details
Attachments
(1 file)
|
716 bytes,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
MSVC-specific code has been enabled for mingw as a side effect of bug 1111255. It works fine except of unknown pragmas warnings. However, GCC branch seems nicer, so I chose that over #ifdefing pragmas.
Attachment #8539828 -
Flags: review?(nfroyd)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 8539828 [details] [diff] [review]
patch.diff
One of these days, I'll actually remember what gets enabled on mingw, and what doesn't, and we can stop breaking things like this. Thanks for the patch!
Attachment #8539828 -
Flags: review?(nfroyd) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
Thanks for quick review.
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0c165a61e9d
|
||
Comment 3•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•