1114388 - Failure in nsAbQueryStringToExpression.cpp : ParseCondition (C-C TB)

Status: NEW

(Thunderbird :: Address Book, defect)

Description

[ISHIKAWA, Chiaki]

Failure in nsAbQueryStringToExpression.cpp : ParseCondition (C-C TB)

Starting in the last pat of November, I see strange errors of
ParseCondition in
comm-central/mailnews/addrbook/src/nsAbQueryStringToExpression.cpp
during the execution of |make mozmill| test suite (running full debug
version of C-C TB).

This was not seen before that timeframe and so fairly new.
(I could have realized a lot sooner if
bug 1111304 did not get in the way.)

After adding a few fprintfs, I found that the failure is caused by
ParseExpression's being passed a rather minimal/incorrect string,
namely, "(and)".  It seems that the string should be something like
"(and (e1 c c) (e2 c2 c3 )..." [that is more components for valid
expressions] and so the parsing failed.
|CreateBooleanConditionString| returns an error which is subsequently
reported.

Somehow the test itself in mozmill passed, but I think there is
something fishy here.

There are about 40 such failures, and here is the excerpted from the log
during |make momizll| test.

Again, this was not seen before the end of November and
is newly introduced issue.

Running against a single test file, iaccount/test-mail-account-setup-wizard.js,
will produce the same error(s).

(debug) *index=<<(and)>> on entry to ParseExpression
(debug) CreateBooleanConditionString failed: and
[578] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file /REF-COMM-CENTRAL/comm-central/mailnews/addrbook/src/nsAbQueryStringToExpression.cpp, line 120
(debug) ParseExpression failed: queryChars=<<)>>
[578] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file /REF-COMM-CENTRAL/comm-central/mailnews/addrbook/src/nsAbMDBDirectory.cpp, line 891
[578] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file /REF-COMM-CENTRAL/comm-central/mailnews/addrbook/src/nsAbMDBDirectory.cpp, line 399
[578] WARNING: NS_ENSURE_TRUE(editor) failed: file /REF-COMM-CENTRAL/comm-central/mozilla/editor/libeditor/nsEditorCommands.cpp, line 584
[578] WARNING: NS_ENSURE_TRUE(editor) failed: file /REF-COMM-CENTRAL/comm-central/mozilla/editor/libeditor/nsEditorCommands.cpp, line 584
[578] WARNING: NS_ENSURE_TRUE(editor) failed: file /REF-COMM-CENTRAL/comm-central/mozilla/editor/libeditor/nsEditorCommands.cpp, line 584
[578] WARNING: NS_ENSURE_TRUE(editor) failed: file /REF-COMM-CENTRAL/comm-central/mozilla/editor/libeditor/nsEditorCommands.cpp, line 584

I don't think the repetition of 
[578] WARNING: NS_ENSURE_TRUE(editor) failed: file /REF-COMM-CENTRAL/comm-central/mozilla/editor/libeditor/nsEditorCommands.cpp, line 584
is related to the particular bug, but
for completeness's sake, I kept it.

During the running of the following, I see many same errors, too.
Rather strange.

TEST-START | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/addrbook/test-address-book.js | setupModule


TIA