Closed
Bug 1114596
Opened 10 years ago
Closed 9 years ago
don't define GENERATED_INCLUDES in ipc/ipdl/moz.build
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla37
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
|
800 bytes,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
The common include file /ipc/chromium/chromium-config.mozbuild already defines this variable for us, and there's no point in telling the compiler to look twice in the same directory for includes.
|
Assignee | |
Comment 1•10 years ago
|
||
The common include file /ipc/chromium/chromium-config.mozbuild already defines this variable for us, and there's no point in telling the compiler to look twice in the same directory for includes.
Attachment #8540152 -
Flags: review?(gps)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8540152 [details] [diff] [review] don't define GENERATED_INCLUDES in ipc/ipdl/moz.build Review of attachment 8540152 [details] [diff] [review]: ----------------------------------------------------------------- I wonder if emitter.py should raise an error if there are duplicate entries. Alternatively, we could make this variable an ordered set.
Attachment #8540152 -
Flags: review?(gps) → review+
|
||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9e1e5d731aa1
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•