1114617 - Remove nsIDownloadManagerUI from Firefox for Android

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Download Manager, defect)

Description

[:Paolo Amadini]

Attachment: Untested patch

From what I can tell, nsIDownloadManagerUI is not called anymore since bug 901360 landed.

Comment 1

[:Margaret Leibovic]

Comment on attachment 8540173 [details] [diff] [review]
Untested patch

Review of attachment 8540173 [details] [diff] [review]:
-----------------------------------------------------------------

I tested this locally, and it appears to work. However, I'm not familiar with the history of this file. How did it work before? What changed in bug 901360? r+ if you can help answer my questions :)

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

I don't think any code even supports calling nsIDownloadManagerUI anymore. Our impl is just dead code.

Comment 3

[:Paolo Amadini]

(In reply to :Margaret Leibovic from comment #1)
> I tested this locally, and it appears to work. However, I'm not familiar
> with the history of this file. How did it work before? What changed in bug
> 901360? r+ if you can help answer my questions :)

This interface was used like a callback by the old Download Manager service, and the "show" method was invoked when a new download started or the global Desktop notification was clicked:

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/downloads/nsDownloadProxy.h#58
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/downloads/nsDownloadManager.cpp#2487

It used to be implemented by the old windowed user interface. The Desktop notification is obviously irrelevant to Android, and the new download notification is controlled by preferences, so I don't even know if it was called before or other notifications were actually used.

Comment 4

[:Margaret Leibovic]

Thanks for the clarification!

Comment 5

[:Paolo Amadini]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=cccbab322aa1

https://hg.mozilla.org/integration/fx-team/rev/917838e59201

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/917838e59201