Create a new test case for the rating feature of the Music App

RESOLVED FIXED

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: njpark, Assigned: njpark)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

5 years ago
This bug is to automate https://moztrap.mozilla.org/manage/case/2682/ , verifying the rating feature of the Music app
Assignee

Updated

5 years ago
No longer depends on: 1112824
Assignee

Updated

5 years ago
Summary: Create a new test case for the restricted access status of FM Radio under airplane mode → Create a new test case for the rating feature of the Music App
Assignee

Updated

5 years ago
Assignee: nobody → npark
QA Whiteboard: [fxosqa-auto-s7]
Assignee

Updated

5 years ago
Blocks: 1114643
Assignee

Updated

5 years ago
No longer blocks: 1114643
Assignee

Comment 1

5 years ago
Since https://moztrap.mozilla.org/manage/case/2682/ is a duplicate of https://moztrap.mozilla.org/manage/case/2683/, 2683 will be automated instead.
Assignee

Comment 2

5 years ago
Attachment #8542356 - Flags: review?(martijn.martijn)
Attachment #8542356 - Flags: review?(jlorenzo)
Comment on attachment 8542356 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27048

Some minor nits.
It would be great if this test could also work on b2g desktop by using an .ogg music file perhaps?
Attachment #8542356 - Flags: review?(martijn.martijn) → review+
Comment on attachment 8542356 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27048

The test is working great on my device. I think we can improve it on the form-perspective; so it would be more pythonic and would respect the currently established conventions in gaia-ui-tests.

I left more details in the PR.
Attachment #8542356 - Flags: review?(jlorenzo) → review-
Assignee

Comment 5

5 years ago
try server passed: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=0e887f46fd41
And comments from the previous reviews are incorporated
Attachment #8542356 - Attachment is obsolete: true
Attachment #8542591 - Flags: review?(jlorenzo)
Comment on attachment 8542591 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27048/files#r22343230

One remaining small nit. After that, can you merge your commits? I'll be ready to merge your PR then!
Attachment #8542591 - Flags: review?(jlorenzo) → review+
Assignee

Comment 7

5 years ago
comments incorporated, and commits squashed.
I kicked of a couple of another treeherder try runs on your latest pull request: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=dab2d02c568e
They were all green, so I merged it: https://github.com/mozilla-b2g/gaia/commit/3ab1b7086144bc2ae87ac8565144e44e411351c3
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.