Closed
Bug 1114662
Opened 10 years ago
Closed 10 years ago
add --enable-thread-sanitizer configure option
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla37
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file, 2 obsolete files)
2.64 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
Like --enable-{address,memory}-sanitizer, this doesn't add the appropriate -fsanitize=FOO flags; it merely sets internal defines and the LLVM_SYMBOLIZER variable.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8540231 -
Flags: review?(mh+mozilla)
Assignee | ||
Comment 2•10 years ago
|
||
Like --enable-{address,memory}-sanitizer, this doesn't add the appropriate -fsanitize=FOO flags; it merely sets internal defines and the LLVM_SYMBOLIZER variable. (Now with correct spelling...)
Attachment #8540231 -
Attachment is obsolete: true
Attachment #8540231 -
Flags: review?(mh+mozilla)
Attachment #8540251 -
Flags: review?(mh+mozilla)
Assignee | ||
Comment 3•10 years ago
|
||
Like --enable-{address,memory}-sanitizer, this doesn't add the appropriate -fsanitize=FOO flags; it merely sets internal defines and the LLVM_SYMBOLIZER variable. (Sigh, we need to add it to js/src/, too.)
Attachment #8540251 -
Attachment is obsolete: true
Attachment #8540251 -
Flags: review?(mh+mozilla)
Attachment #8540331 -
Flags: review?(mh+mozilla)
Comment 4•10 years ago
|
||
Comment on attachment 8540331 [details] [diff] [review] add --enable-thread-sanitizer configure option Review of attachment 8540331 [details] [diff] [review]: ----------------------------------------------------------------- At some point, we may just want to replace all those options with --enable-sanitizer=foo,bar,baz.
Attachment #8540331 -
Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/a5923764a615
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•