Closed
Bug 1114822
Opened 10 years ago
Closed 9 years ago
Make standalone server location configurable for tests
Categories
(Hello (Loop) :: Client, defect)
Hello (Loop)
Client
Tracking
(Not tracked)
People
(Reporter: drno, Assigned: drno)
Details
Attachments
(1 file)
|
1.32 KB,
patch
|
dmosedale
:
review+
|
Details | Diff | Splinter Review |
The current code assume that the standalone server code lives relative to the test files itself. This prevents us from running the current test against an older release of the standalone server. We should have an optional way of specifying the standalone server to be used for the given test run.
|
Assignee | |
Comment 1•10 years ago
|
||
This patch adds an optional env variable check for STANDALONE_SERVER, which will allows us to point the test to a different location (checkout/version) of the standalone server.
Attachment #8540448 -
Flags: review?(dmose)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8540448 [details] [diff] [review] bug_1114822_make_standalone_location_configurable.patch Review of attachment 8540448 [details] [diff] [review]: ----------------------------------------------------------------- Looks good; r=dmose!
Attachment #8540448 -
Flags: review?(dmose) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
As this touches only a test which never is executed on TBPL I think we don't need a try run :-)
Keywords: checkin-needed
|
||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/87b7c943c2d6
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla37
|
||
Updated•9 years ago
|
Iteration: --- → 37.2
You need to log in
before you can comment on or make changes to this bug.
Description
•