1114824 - fix telemetry for TRACKING_PROTECTION_SHIELD

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[[:mmc] Monica Chew (no longer reading bugmail)]

We want to be able to calculate things like
- % of page loads that are affected by tracking protection.

The current telemetry is wrong for this. In TRACKING_PROTECTION_SHIELD, numbers are 
- 0 (16.5G), number of times the shield is not shown
- 1 (3.9K), tracking content is loaded
- 2 (58K), tracking content is blocked
- 3 (147M), shield is shown due to mixed content.

Buckets 0 and 3 need to be predicated on the user having tracking protection enabled. Otherwise all we know is that when tracking protection is active and there is tracking content on the page, it's loaded about 6% of the time.

Comment 1

[[:mmc] Monica Chew (no longer reading bugmail)]

Attachment: Fix TRACKING_PROTECTION_SHIELD

Comment 2

[[:mmc] Monica Chew (no longer reading bugmail)]

Comment on attachment 8540452 [details] [diff] [review]
Fix TRACKING_PROTECTION_SHIELD

Review of attachment 8540452 [details] [diff] [review]:
-----------------------------------------------------------------

In case one of you is working over the holiday weeks :)

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 8540452 [details] [diff] [review]
Fix TRACKING_PROTECTION_SHIELD

Review of attachment 8540452 [details] [diff] [review]:
-----------------------------------------------------------------

Ho ho ho.

Comment 4

[[:mmc] Monica Chew (no longer reading bugmail)]

Thanks, Blair :)

Comment 5

[[:mmc] Monica Chew (no longer reading bugmail)]

https://hg.mozilla.org/integration/fx-team/rev/284aacd7c045

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/284aacd7c045