1114864 - Request to add Igbo (ig) keyboard to Firefox OS

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Delphine Lebédel]

Request to add Igbo (ig) locale to Firefox OS

Comment 1

[Delphine Lebédel]

[Blocking Requested - why for this release]:
Requested for 2.0 and onwards. Thus nominating

Comment 2

[Wesly Huang (EPM)]

[Blocking Requested - why for this release]:

[Triage] Considering current 2.0 timing and the need from partner, nom. to 2.1 (or even 2.2?) instead for consideration.

Comment 3

[bhavana bajaj [:bajaj]]

Clearing blocking nom, refer to comment in : https://bugzilla.mozilla.org/show_bug.cgi?id=1114866

Comment 4

[Delphine Lebédel]

Adding localizers who might be able to help in the meantime with keyboard input. thanks!

Comment 5

[Delphine Lebédel]

No answer from localizers, so asking Peiying if she can plug in Rubric to help with review, as well as Bruce so he can help drive this on the keyboard side.
Thanks all!

Comment 6

[Bruce Huang [:bhuang] (inactive)]

Layout here for review: http://goo.gl/vApmyz.

Adding to backlog.

Comment 7

[Peiying Mo [:CocoMo]]

+ Devon & Ian

Comment 8

[ian.henderson]

Our translator has indicated this keyboard is a complete Igbo keyboard: http://www.stars21.com/keyboard/igbo_keyboard.html

Comment 9

[Peiying Mo [:CocoMo]]

Is there anything else needed from me for this?

Comment 10

[Delphine Lebédel]

Bruce: keyboard feedback is given in comment 8. 
Blocking 2.1 on this as per the mana (cross-functional view).
Please let us know if you need any thing else!

Comment 11

[Bruce Huang [:bhuang] (inactive)]

Confirmed that the letters are all available as indicated in comment 8.  I had to modify to fit in our standard layout since that link just indicates all available letters.

http://goo.gl/vApmyz

Rudy, can you check and see if you have any questions on the layout?

Comment 12

[GitHub Autolander Bot]

Attachment: [gaia] RudyLu:keyboard/Bug1114864-igbo_layout > mozilla-b2g:master

Comment 13

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8602079 [details] [review]
[gaia] RudyLu:keyboard/Bug1114864-igbo_layout > mozilla-b2g:master

The layout is ready for review.

--
Arky, could you please give feedback on the layout?
Beside, please help review that "Asụsụ Igbo" is the correct (native) name for this layout.
Thanks.

Comment 14

[Bruce Huang [:bhuang] (inactive)]

Attachment: Igbo keyboard screenshots

Screenshots of Igbo keyboard including secondary characters.

Comment 15

[Peiying Mo [:CocoMo]]

Ian and Devon, 

Please review the layout in comment #14 and confirm whether it is ok.  There is minor font issue the team is still trying to resolve but the work won't affect the layout.

Comment 16

[Devon]

Hello All,

Our Igbo translators confirmed that the layout of the keyboard is correct.

Thank you,
Devon

Comment 17

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8602079 [details] [review]
[gaia] RudyLu:keyboard/Bug1114864-igbo_layout > mozilla-b2g:master

Take comment 16 as a feedback+ on this patch.

Thanks.

Comment 18

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#H3Mw6mD4TPqUvcv-cj4EHQ

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 19

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/be82b6edc1221f041f282b68570bbe3975b5ffec

Comment 20

[Ryan VanderMeulen [:RyanVM]]

Please request Gaia v2.1 and v2.2 approval on this when you get a chance.

Comment 21

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8602079 [details] [review]
[gaia] RudyLu:keyboard/Bug1114864-igbo_layout > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined:
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Feature, a new keyboard layout.
[User impact] if declined: No Igbo layout for Igbo users.
[Testing completed]: Manually by patch author
[Risk to taking this patch] (and alternatives if risky): Low since this layout won't be built by default unless explicitly set for each branch.
[String changes made]: N/A.

Comment 22

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Please don't uplift to v2.1 since we would need a branch-specific patch for that.
Thanks.

Comment 23

[Josh Cheng [:josh]]

Comment on attachment 8602079 [details] [review]
[gaia] RudyLu:keyboard/Bug1114864-igbo_layout > mozilla-b2g:master

Approving as this only add new keyboard layout.

Hi Vance,
Do we have any release plan for 2.1 devices?
Thanks!

Comment 24

[Vance Chen [:vchen][skype:vance.lucida][[e-mail]]]

Yes, we might have partners from Nigeria that want this keyboard for 2.1s as well...Would it be too difficult to uplift it to 2.1s ?

Thanks

Comment 25

[Josh Cheng [:josh]]

Comment on attachment 8602079 [details] [review]
[gaia] RudyLu:keyboard/Bug1114864-igbo_layout > mozilla-b2g:master

Thanks Vance!
Approve for 2.1 per comment 24 as this might requested by partner.

Comment 26

[Josh Cheng [:josh]]

Comment on attachment 8602079 [details] [review]
[gaia] RudyLu:keyboard/Bug1114864-igbo_layout > mozilla-b2g:master

Hi Vance,
Thanks for the info.

@Rudy,
Please raise 2.1 uplift approval when you have 2.1 branch patch ready.
Thanks!

Comment 27

[Coler]

This bug has been verified as "pass" on latest build of Flame 3.0, Nexus5_3.0.
STR:
1. Launch Settings->keyboard.
**The Asusu Igbo keyboard can be found in the list.
2. Check Asusu Igbo keyboad.
3. Launch Message, create a new message.
4. Try to change keyboard to Asusu Igbo.
**Keyboard is changed successfully.

Actual result:The Igbo keyboard has been added to device.

See attachment:Verify3.0.3gp
Reproducing rate: 0/5

Device: Flame 3.0 build(Pass):
Build ID               20150614010203
Gaia Revision          1bf2da102560481748ff3f6202fbed5c4daa5832
Gaia Date              2015-06-13 00:22:05
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/c223b8844264
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150614.044513
Firmware Date          Sun Jun 14 04:45:25 EDT 2015
Bootloader             L1TC000118D0

Device:Nexus5_3.0 build(Pass):
Build ID               20150614010203
Gaia Revision          1bf2da102560481748ff3f6202fbed5c4daa5832
Gaia Date              2015-06-13 00:22:05
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/c223b8844264
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150614.044149
Firmware Date          Sun Jun 14 04:42:08 EDT 2015
Bootloader             HHZ12f

Comment 28

[Coler]

Attachment: Verify3.0.3gp

Comment 29

[Ryan VanderMeulen [:RyanVM]]

This needs rebasing for v2.2 as well.

Comment 30

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Patch for v2.2

Comment 31

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Patch for v2.1

Comment 32

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8622983 [details] [review]
Patch for v2.1

Now, the patches for both v2.2 and v2.1 are ready.
See comment 21 for the approval request reasons.

Thanks.

Comment 33

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/c01965c79c21644e13aa7ffa98cf29f835f4961a

Comment 34

[Josh Cheng [:josh]]

Comment on attachment 8622983 [details] [review]
Patch for v2.1

Approving as branch patch provided.

Comment 35

[Coler]

This bug has been verified as "Fail" on latest build of Flame2.2 and Nexus 5_2.2, the STR is same as Comment 27.Should we file a new bug?

Note:
In Flame 2.2, even change system language to Asusu Igbo,the keyboard can't be found in list either.
In Nexus 5_v2.2, no Asusu Igbo language.

Actual result:Don't find Igbo keyboard in the list.
Time:09:27
See attachments:logcat_0927.txt, 2.2_Fail.3gp
Reproducing rate: 5/5

Flame 2.2:(Fail)
Build ID               20150624162504
Gaia Revision          1f8981d7872e3c0053571c26fb3edaf401844d75
Gaia Date              2015-06-19 13:22:30
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/2f8b845e5fa3
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150624.195750
Firmware Date          Wed Jun 24 19:58:02 EDT 2015
Bootloader             L1TC000118D0

Nexus5_2.2:(Fail)
Build ID               20150625162500
Gaia Revision          1f8981d7872e3c0053571c26fb3edaf401844d75
Gaia Date              2015-06-19 13:22:30
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/2f8b845e5fa3
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150625.212626
Firmware Date          Thu Jun 25 21:26:45 EDT 2015
Bootloader             HHZ12f

Comment 36

[Coler]

Attachment: 2.2_Fail.3gp

Comment 37

[Coler]

Attachment: logcat_0927.txt

Comment 38

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

For v2.2, you have to specify including the newly added keyboard layout when building Gaia,
  |GAIA_KEYBOARD_LAYOUTS=en,pt-BR,es,de,fr,fr-CA,pl,ko,zh-Hans-Pinyin,en-Dvorak,ig make install-gaia|

or, it won't be built.

Could you please help verify it again with the above addition?
Thanks.

Comment 39

[Coler]

Hi Rudy,
We add these keyboards by follow steps:

1. Clone following language files to gaia/locals folder: de,es,en-US,fr,ig,pt-BR,ko,pl,zh-CN, and add a file named language.json in which you should place the required languages. Then add the .userconfig to flame-kk folder, and add the following command:
export LOCALE_BASEDIR=/home/workspace/flame-kk/gaia/locales
export LOCALES_FILE=/home/workspace/flame-kk/gaia/locales/languages.json
export GAIA_DEFAULT_LOCALE=de,es,en-US,fr,ig,pt-BR,ko,pl,zh-CN
export GAIA_KEYBOARD_LAYOUTS=en,pt-BR,es,de,fr,fr-CA,pl,ko,zh-Hans-Pinyin,en-Dvorak,ig
2.Build and flash this gaia.

Verify the bug with this build, the result is "Pass". Could you help to check it? Thanks!
Attachment:Verify_2.2.3gp

Comment 40

[Coler]

Attachment: Verify_2.2.3gp

Comment 41

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Thanks for your help to re-verify this issue on v2.2.
I think the test steps look good to me.

Thanks.

Comment 42

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/7080a7c28b0242f81d689d2339dfa1177e23f48f