Closed Bug 1114878 Opened 11 years ago Closed 11 years ago

Correct the size of the Sheriffs menu button

Categories

(Tree Management :: Treeherder, defect, P4)

Product:
Tree Management
Component:
Treeherder
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: jfrench, Assigned: jfrench)

References

(
URL
)

Details

Attachments

(1 file)

treeherder-PR#311
49 bytes, text/x-github-pull-request
camd
: review+
Details | Review
The Sheriffs menu button evidently did not receive the same size adjustment during the navbar polish work. Now that I can readily see the Sheriff menu I can see it is too large (14px), has the incorrect padding for its hover cell, and needs to be similarly tweaked.
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
Attached file treeherder-PR#311 —
Please see above PR for review and status.
Attachment #8540537 - Flags: review?(cdawson)
Commits pushed to master at https://github.com/mozilla/treeherder-ui https://github.com/mozilla/treeherder-ui/commit/a6e7734142ebaade08d853bd8cf6d561471a5176 Bug 1114878 - Correct the size of the Sheriffs menu button https://github.com/mozilla/treeherder-ui/commit/0b13102655d759431220bf1a49ccbbeb50cc9217 Merge pull request #311 from tojonmz/sheriff-menu-size Bug 1114878 - Correct the size of the Sheriffs menu button
Attachment #8540537 - Flags: review?(cdawson) → review+
Marking Fixed per the above merge. Will mark Verified once it's pushed to prod.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Actually, verified fixed on stage.
Status: RESOLVED → VERIFIED
Commits pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/320de839d5e08895e9d10585bb6dc58da6e95ec2 Bug 1114878 - Correct the size of the Sheriffs menu button https://github.com/mozilla/treeherder/commit/69b2e594d5e23581be01195f3efc6efc8971d690 Merge pull request #311 from tojonmz/sheriff-menu-size Bug 1114878 - Correct the size of the Sheriffs menu button
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: