Closed
Bug 1114946
Opened 8 years ago
Closed 5 years ago
"Private Tab" add-on does not work with e10s
Categories
(Firefox :: Extension Compatibility, defect)
Tracking
()
RESOLVED
INCOMPLETE
Tracking | Status | |
---|---|---|
e10s | + | --- |
People
(Reporter: bullionareboy, Unassigned)
References
()
Details
Well it does open link when i click "Open in New Private Tab" but the tab is not in "Private mode" Only after right-clicking the specific tab and choosing "Private Tab" is the private mode being enabled(Confirming it by the appearance of the private eye-mask icon on the left end of the tab list)
Blocks: e10s-addons
Comment 1•8 years ago
|
||
Infocatcher, are you the developer of the "Private Tab" add-on? The add-on seems to be broken with multiprocess Firefox (e10s). If you have any questions about e10s support, just drop by the #e10s IRC channel on irc.mozilla.org or ask Ally on this bug. MDN also has a good introduction: https://developer.mozilla.org/en-US/Add-ons/Working_with_multiprocess_Firefox https://addons.mozilla.org/en-US/firefox/addon/private-tab/
tracking-e10s:
--- → +
Comment 2•8 years ago
|
||
I know... https://github.com/Infocatcher/Private_Tab/issues/162 The main problem is here: https://github.com/Infocatcher/Private_Tab/blob/1b423d6d232cefd0b68da122e7fc98a9c2ae7d9e/bootstrap.js#L3792-L3799 All works fine (oh, with compatibility shims, but it's easy to rewrite with browser.contentWindowAsCPOW) for already opened tabs (using checkbox in tab context menu, but what to do on "TabOpen" event? It seems that things aren't initialized yet...
Updated•8 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 4•8 years ago
|
||
This appears to be working correctly with the latest version, would you like me to close this bug? Also, sweet add-on.
Flags: needinfo?(infocatcher.bugs)
Comment 5•8 years ago
|
||
Define "latest"; it's still broken in 42.0a2. The tab gives every appearance of being private, but history is still recorded.
Comment 6•8 years ago
|
||
(In reply to Thijs van Dijk from comment #5) > Define "latest"; it's still broken in 42.0a2. The tab gives every appearance > of being private, but history is still recorded. I was only checking on the reported bug, that it wasn't indicating private mode.
Comment 7•8 years ago
|
||
Many things was corrected in latest development version (https://github.com/Infocatcher/Private_Tab), but at least private: protocol (and therefore items in task bar menu on Windows) still doesn't work. Also still broken detection of drag-and-drop into editable text-like nodes. And probably something else. Is there some bug about registration of nsIProtocolHandler implementations? May be similar code also should be called from frame script, but this looks really strange to do something, that should be done from browser side.
Flags: needinfo?(infocatcher.bugs)
Comment 8•8 years ago
|
||
I think bug 1095484 may be related. Comment 22 in bug 940206 may help some.
Comment 9•7 years ago
|
||
New Private Tab 0.2.0 currently working with e10s enabled Version 51.0a2 Build ID 20161005004013
Flags: needinfo?(infocatcher.bugs)
Comment 10•7 years ago
|
||
(In reply to Michelle Funches - QA from comment #9) > New Private Tab 0.2.0 currently working with e10s enabled Yes, most of features should work fine now. Also in development version was corrected CPOWs usage: https://github.com/Infocatcher/Private_Tab/issues/234
Flags: needinfo?(infocatcher.bugs)
Comment 11•5 years ago
|
||
With Firefox 57 only WebExtensions are permitted and are, by default, e10s compatible.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INCOMPLETE
You need to log in
before you can comment on or make changes to this bug.
Description
•