1114989 - Convert Shmem::mSegment to nsRefPtr

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Comment 1

[(no longer active)]

Attachment: Convert Shmem::mSegment to nsRefPtr

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This originally landed in https://hg.mozilla.org/integration/mozilla-inbound/rev/45798e9a16c2 but it broke all of the linux builds like https://treeherder.mozilla.org/ui/logviewer.html#?job_id=4923516&repo=mozilla-inbound

Ehsan followed up with https://hg.mozilla.org/integration/mozilla-inbound/rev/5910d49fed08 to fix the bustage, but now I'm seeing failures like https://treeherder.mozilla.org/ui/logviewer.html#?job_id=4926354&repo=mozilla-inbound

Both of those commits are backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/40dace0ebf7c and https://hg.mozilla.org/integration/mozilla-inbound/rev/5aaf3f3a87f1 to get the tree opened again.

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Other failures included https://treeherder.mozilla.org/ui/logviewer.html#?job_id=4926697&repo=mozilla-inbound

Comment 4

[(no longer active)]

Looking at the generated IPDL code, this member is treated as a non-owning pointer, so I marked it as such:

https://hg.mozilla.org/integration/mozilla-inbound/rev/834d27e2c025

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/834d27e2c025