Closed Bug 1115075 Opened 8 years ago Closed 8 years ago
Add telemetry for DBUtils
.ensure Database Is Not Locked
So we know whether to yank it.
Obvious concern: if this prevents us from staying alive long enough for Gecko to run and submit telemetry, we won't get anything. So this'll be something of a canary: if we get results in telemetry, it means that it's working; if we get silence, that means it's not working.
I don't know why I landed this with such a weird name.
Attachment #8540858 - Flags: review?(mark.finkle)
Not yet tested, but this should do the trick.
Attachment #8540860 - Flags: review?(mark.finkle)
Comment on attachment 8540858 [details] [diff] [review] Part 0: rename HistogramAdd -> addToHistogram. v1 My OCD thanks you
Attachment #8540858 - Flags: review?(mark.finkle) → review+
Attachment #8540860 - Flags: review?(mark.finkle) → review+
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
ni me for potential Aurora uplift.
Comment on attachment 8540860 [details] [diff] [review] Add telemetry for DBUtils.ensureDatbaseIsNotLocked. v1 Approval Request Comment [Feature/regressing bug #]: None. Adding telemetry. [User impact if declined]: N/A [Describe test coverage new/current, TBPL]: If this were to impact the success case, we'd see it on Nightly. If it impacts the failure case (which it should not), then I'm hoping we get telemetry! [Risks and why]: We have some hacky code in the tree to try to recover from database locks. I don't think it works, so I'd like to add telemetry to find out. [String/UUID change made/needed]: None.
Attachment #8540860 - Flags: approval-mozilla-aurora?
Attachment #8540860 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.