Closed
Bug 1115075
Opened 9 years ago
Closed 9 years ago
Add telemetry for DBUtils.ensureDatabaseIsNotLocked
Categories
(Firefox for Android Graveyard :: Data Providers, defect)
Tracking
(firefox36 fixed, firefox37 fixed)
RESOLVED
FIXED
Firefox 37
People
(Reporter: rnewman, Assigned: rnewman)
References
Details
Attachments
(2 files)
23.47 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
5.35 KB,
patch
|
mfinkle
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
So we know whether to yank it.
Assignee | ||
Comment 1•9 years ago
|
||
Obvious concern: if this prevents us from staying alive long enough for Gecko to run and submit telemetry, we won't get anything. So this'll be something of a canary: if we get results in telemetry, it means that it's working; if we get silence, that means it's not working.
Assignee | ||
Comment 2•9 years ago
|
||
I don't know why I landed this with such a weird name.
Attachment #8540858 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 3•9 years ago
|
||
Not yet tested, but this should do the trick.
Attachment #8540860 -
Flags: review?(mark.finkle)
Comment 4•9 years ago
|
||
Comment on attachment 8540858 [details] [diff] [review] Part 0: rename HistogramAdd -> addToHistogram. v1 My OCD thanks you
Attachment #8540858 -
Flags: review?(mark.finkle) → review+
Updated•9 years ago
|
Attachment #8540860 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/8c93e281718e https://hg.mozilla.org/integration/fx-team/rev/6441c30a1317
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8c93e281718e https://hg.mozilla.org/mozilla-central/rev/6441c30a1317
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Assignee | ||
Comment 8•9 years ago
|
||
Comment on attachment 8540860 [details] [diff] [review] Add telemetry for DBUtils.ensureDatbaseIsNotLocked. v1 Approval Request Comment [Feature/regressing bug #]: None. Adding telemetry. [User impact if declined]: N/A [Describe test coverage new/current, TBPL]: If this were to impact the success case, we'd see it on Nightly. If it impacts the failure case (which it should not), then I'm hoping we get telemetry! [Risks and why]: We have some hacky code in the tree to try to recover from database locks. I don't think it works, so I'd like to add telemetry to find out. [String/UUID change made/needed]: None.
Flags: needinfo?(rnewman)
Attachment #8540860 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
status-firefox36:
--- → affected
status-firefox37:
--- → fixed
Updated•9 years ago
|
Attachment #8540860 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 9•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/790d52784837 https://hg.mozilla.org/releases/mozilla-aurora/rev/0ac83d90d977
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•