Closed Bug 1115076 Opened 7 years ago Closed 7 years ago

test_sts_privatebrowsing_perwindowpb.html fails when run as a standalone directory

Categories

(Core :: Security: PSM, defect)

All
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: vaibhav1994, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

in bug 1110982, we are looking to enable tests where we run a fresh browser instance per directory.  Usually what happens is that a few tests fail because they accidentally depend on the state of the browser from an earlier test.

In the try run:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=1a5fa04f057a

In the linux opt/debug oth chunks, the test fails as following:
 2349 INFO TEST-UNEXPECTED-FAIL | security/manager/ssl/tests/mochitest/stricttransportsecurity/test_sts_privatebrowsing_perwindowpb.html | Test timed out. - expected PASS
this is failing locally for me, I verified I have e10s turned off and I get:

./mach mochitest-chrome security/manager/ssl/tests/mochitest
.
:
135 INFO State of example.com: true
136 INFO TEST-PASS | security/manager/ssl/tests/mochitest/stricttransportsecurity/test_sts_privatebrowsing_perwindowpb.html | in ROUND plain, test alreadysecure 
137 INFO DONE WITH ROUND plain
138 INFO Cleaning up STS data
139 INFO State of example.com: false
-*-*- UserCustomizations (parent): document created: http://mochi.test:8888/chrome/security/manager/ssl/tests/mochitest/stricttransportsecurity/page_blank.html
-*-*- UserCustomizations (parent): _injectInWindow
-*-*- UserCustomizations (parent): principal status: 0
140 INFO In private window
141 INFO State of example.com: false
142 INFO TESTS LEFT IN ROUND subdom: 4
WARNING: content window passed to PrivateBrowsingUtils.isWindowPrivate. Use isContentWindowPrivate instead (but only for frame scripts).
pbu_isWindowPrivate@resource://gre/modules/PrivateBrowsingUtils.jsm:25:14
@chrome://browser/content/aboutPrivateBrowsing.js:12:6
WARNING: content window passed to PrivateBrowsingUtils.isWindowPrivate. Use isContentWindowPrivate instead (but only for frame scripts).
pbu_isWindowPrivate@resource://gre/modules/PrivateBrowsingUtils.jsm:25:14
@chrome://browser/content/aboutPrivateBrowsing.js:37:8
^Cruntests.py | Received keyboard interrupt.
The test passes, if I comment out this line:
http://dxr.mozilla.org/mozilla-central/source/security/manager/ssl/tests/mochitest/stricttransportsecurity/test_sts_privatebrowsing_perwindowpb.html#217

of course this isn't testing private browsing really.

I did notice this has similar code to dom/tests/mochitest/localstorage/test_localStorageQuotaPrivateBrowsing_perwindowpb.html which is failing as well in bug 1115063.

:ehsan, you have been involved in both of these bugs, do you have more information why these specific tests might be failing when run as a single directory?
Flags: needinfo?(ehsan)
How do I reproduce this?  For me, both ./mach mochitest-chrome security/manager/ssl/tests/mochitest/stricttransportsecurity/ and ./mach mochitest-chrome security/manager/ssl/tests/mochitest/ pass locally.
Flags: needinfo?(ehsan) → needinfo?(jmaher)
hmm, maybe there is a difference in our environments.  I am running linux64 (ubuntu 14.04) with a local build in opt mode.  Is there something I could provide to help determine why this fails for me locally as I outlined in comment #1 ?
Flags: needinfo?(jmaher)
Oh hmm, this seems to be Linux specific.  I'll take a look on Linux, probably next week.
Flags: needinfo?(ehsan)
We end up loading about:privatebrowsing in the middle of this test, which is why it times out.
Assignee: nobody → ehsan
Flags: needinfo?(ehsan)
Attachment #8542669 - Flags: review?(josh) → review+
https://hg.mozilla.org/mozilla-central/rev/2aabdc20a0da
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.