1115078 - memory/build/mozjemalloc_compat.c:13:83: fatal error: jemalloc/internal/jemalloc_internal_defs.h: No such file or directory

Status: RESOLVED FIXED

(Core :: Memory Allocator, defect)

Description

[Jan Beich]

FreeBSD uses MOZ_NATIVE_JEMALLOC by default. It's API is limited to <stdlib.h> and <malloc_np.h>. Even version from git dev never installs headers under include/jemalloc/internal/.

$ MOZ_JEMALLOC3=1 ./mach build
...
memory/build/mozjemalloc_compat.c:13:10: fatal error:
      'jemalloc/internal/jemalloc_internal_defs.h' file not found
#include "jemalloc/internal/jemalloc_internal_defs.h" // for JEMALLOC_HAS_ALLOCA_H
         ^
1 error generated.

Comment 1

[Jan Beich]

Attachment: fix

NPOTB but worth Try run when it's open.

Comment 2

[Guilherme Gonçalves [:ggp]]

Comment on attachment 8540895 [details] [diff] [review]
fix

I can't give you a formal review, but this does look good to me. Thanks, and sorry for breaking your build.

Comment 3

[Jan Beich]

Green with MOZ_JEMALLOC3: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=1408903e87fe

Comment 4

[Guilherme Gonçalves [:ggp]]

Are you sure that has MOZ_JEMALLOC3? I usually need to do something like https://hg.mozilla.org/try/rev/aab97774f1c3 when pushing to try.

Comment 5

[Jan Beich]

Sure, ACDEFINES has -DMOZ_JEMALLOC3='1'. I was lazy and edited configure.in instead of figuring which mozconfig Try server uses, how to write one shared between different platforms and what's the order mozconfig files are read.

https://hg.mozilla.org/try/rev/1408903e87fe

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b1b9af321bac

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b1b9af321bac