Closed Bug 1115083 Opened 10 years ago Closed 6 years ago

Intermittent day_observer_test.js | day_observer cached #on: yesterday + persist + remove + visibility - AssertionError: expected 1 to equal 2 (:0)

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Calendar
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: RyanVM, Assigned: mmedeiros)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

[PullReq] millermedeiros:1115083-intermittent-day-observer-test to mozilla-b2g:master
46 bytes, text/x-github-pull-request
gaye
: review+
Details | Review 
07:45:34 INFO - TEST-START | calendar/test/unit/day_observer_test.js
07:45:34 INFO - TEST-INFO | calendar/test/unit/day_observer_test.js | log: app [calendar] "Configure calendar with db and router."
07:45:34 INFO - TEST-PASS | calendar/test/unit/day_observer_test.js | day_observer empty cache #on: today
07:45:34 INFO - TEST-PASS | calendar/test/unit/day_observer_test.js | day_observer empty cache #findAssociated
07:45:34 INFO - TEST-PASS | calendar/test/unit/day_observer_test.js | day_observer cached #on: today
07:45:34 INFO - TEST-PASS | calendar/test/unit/day_observer_test.js | day_observer cached #on: tomorrow
07:45:34 INFO - TEST-PASS | calendar/test/unit/day_observer_test.js | day_observer cached #on: yesterday
07:45:34 INFO - JavaScript error: , line 0: AssertionError: expected 1 to equal 2
07:45:34 INFO - TEST-UNEXPECTED-FAIL | calendar/test/unit/day_observer_test.js | day_observer cached #on: yesterday + persist + remove + visibility - AssertionError: expected 1 to equal 2 (:0)
07:45:34 INFO - Error: AssertionError: expected 1 to equal 2 (:0)
07:45:34 INFO - at onerror (app://calendar.gaiamobile.org/common/vendor/mocha/mocha.js:4959:10)
07:45:34 INFO - TEST-PASS | calendar/test/unit/day_observer_test.js | day_observer cached #findAssociated
07:45:34 INFO - TEST-OK | calendar/test/unit/day_observer_test.js | took 594ms
Is ay_observer the Fonzie test?
Summary: Intermittent ay_observer_test.js | day_observer cached #on: yesterday + persist + remove + visibility - AssertionError: expected 1 to equal 2 (:0) → Intermittent day_observer_test.js | day_observer cached #on: yesterday + persist + remove + visibility - AssertionError: expected 1 to equal 2 (:0)
going to fix this today... getting mad with all the notifications on my email.

`busytimeStore.persist` can take way longer than expected on gaia-try so `dayObserver.on` callback might be triggered between 2 `persist` calls.
Assignee: nobody → mmedeiros
Attachment #8552630 - Flags: review?(gaye)
Comment on attachment 8552630 [details] [review]
[PullReq] millermedeiros:1115083-intermittent-day-observer-test to mozilla-b2g:master

Feel free to land when CI goes green.
Attachment #8552630 - Flags: review?(gaye) → review+
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
The commit for comment 62 has merged around but we're still hitting this.
Status: RESOLVED → REOPENED
Flags: needinfo?(mmedeiros)
Resolution: FIXED → ---
the error now is a little bit different.. before it was "expected 1 to equal 2" now it is "expected 2 to equal 1".... so I'll need to add the same hack to each one of the steps (everything is async and events might get fired at weird timing on gaia-try because db is slower...)
Flags: needinfo?(mmedeiros)
Can we just disable this test already?
Flags: needinfo?(mmedeiros)
RyanVM, this test was supposed to be disabled since Feb 2: https://github.com/mozilla-b2g/gaia/commit/3f55ab2669f13d0172b7fcc5105ed55e0ab6e33b#diff-ee20aa35354a2b3caa315a985cb392f0

if `dayObserver` is broken all the views won't display the events, so it's very unlikely that we will introduce unnoticed regressions here... and marionette tests already checks the basic features (deleting events, adding events, modifying events..)

maybe one day I find the time to write the proper unit tests. this was failing because we should be using mocks since the beginning for the database calls. We'll replace the DB logic in the next couple months, so maybe after that we can revisit this.
Flags: needinfo?(mmedeiros)
Closing all intermittent test failures for Firefox OS (since we're not focusing on it anymore).

Please reopen if my search included your bug by mistake.
Firefox OS is not being worked on
Status: REOPENED → RESOLVED
Closed: 9 years ago → 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: