fix signed/unsigned comparison warnings in mailnews/local/src/nsLocalUndoTxn.cpp

RESOLVED FIXED in Thunderbird 37.0

Status

defect
--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

Trunk
Thunderbird 37.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

/var/SSD/TB-hg/mailnews/local/src/nsLocalUndoTxn.cpp: In member function 'virtual nsresult nsLocalMoveCopyMsgTxn::OnItemAdded(nsIMsgFolder*, nsISupports*)':
mailnews/local/src/nsLocalUndoTxn.cpp:435:47: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     if (m_copiedMsgIds.IndexOf(messageId) != kNotFound)
                                               ^
mailnews/local/src/nsLocalUndoTxn.cpp:443:54: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
       if (++m_numHdrsCopied == m_copiedMsgIds.Length())
                                                      ^
Posted patch patchSplinter Review
Attachment #8540900 - Flags: review?(neil)
Attachment #8540900 - Flags: review?(neil) → review+
Thanks.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/9ec556805476 -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
OS: Linux → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 37.0
You need to log in before you can comment on or make changes to this bug.