Closed Bug 1115153 Opened 5 years ago Closed 5 years ago
Loop: Create API to allow web to retrieve the loop
.getting Started .seen pref
Create new API to allow the web to get the value set in the loop.gettingStarted.seen value in about:config. This will be used to show users different content in the /whatsnew and /firstrun tours. Targeting Fx 36.
Turns out we don't need this for whatnew, but we will for snippets. We can suppress whatsnew in-product if you've previously seen the tour, but we can't suppress snippets.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Iteration: --- → 38.2 - 9 Feb
The plan was to use getConfiguration for this. e.g. getConfiguration("loop"); and return the pref value as a property e.g. `gettingStartedSeen: true,` like we do with getConfiguration("sync") that way we can add other loop prefs later without having to have a new key for getConfiguration. See https://mxr.mozilla.org/mozilla-central/source/browser/components/uitour/UITour.jsm?rev=872fa257eee2&mark=1406-1408,1437#1400
Comment on attachment 8555410 [details] [diff] [review] Patch Review of attachment 8555410 [details] [diff] [review]: ----------------------------------------------------------------- Stealing the review since it's pretty straightforward
Attachment #8555410 - Flags: review?(mdeboer) → review+
Points: --- → 2
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 36 → Firefox 38
Comment on attachment 8555410 [details] [diff] [review] Patch Approval Request Comment [Feature/regressing bug #]: Bug 1118874 - Hello tour/snippet/product page for 36 [User impact if declined]: Tour pages (primarily about:home snippets) cannot know if the Hello button is in the nav-bar. [Describe test coverage new/current, TreeHerder]: m-bc test added. [Risks and why]: Low risk isolated to UITour. Worst case www.mozilla.org just doesn't use problematic APIs. This is a simple addition to an existing API that was used previously. [String/UUID change made/needed]: None RyanVM/others: Note that I will do uplifts myself since there are many UITour patches to uplift in the correct order.
You need to log in before you can comment on or make changes to this bug.