Closed
Bug 1115153
Opened 6 years ago
Closed 6 years ago
Loop: Create API to allow web to retrieve the loop.gettingStarted.seen pref
Categories
(Firefox :: Tours, defect)
Firefox
Tours
Tracking
()
People
(Reporter: ckprice, Assigned: jaws)
References
Details
(Whiteboard: [UITour:P1])
Attachments
(1 file)
3.73 KB,
patch
|
MattN
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Create new API to allow the web to get the value set in the loop.gettingStarted.seen value in about:config. This will be used to show users different content in the /whatsnew and /firstrun tours. Targeting Fx 36.
Reporter | ||
Updated•6 years ago
|
status-firefox36:
--- → affected
Summary: (Hello) Create API to allow web to retrieve the loop.gettingStarted.seen pref → Loop: Create API to allow web to retrieve the loop.gettingStarted.seen pref
Reporter | ||
Updated•6 years ago
|
Blocks: fx-UITour-hello-36
Comment 1•6 years ago
|
||
Turns out we don't need this for whatnew, but we will for snippets. We can suppress whatsnew in-product if you've previously seen the tour, but we can't suppress snippets.
Updated•6 years ago
|
Whiteboard: [UITour:P1]
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Iteration: --- → 38.2 - 9 Feb
Comment 2•6 years ago
|
||
The plan was to use getConfiguration for this. e.g. getConfiguration("loop"); and return the pref value as a property e.g. `gettingStartedSeen: true,` like we do with getConfiguration("sync") that way we can add other loop prefs later without having to have a new key for getConfiguration. See https://mxr.mozilla.org/mozilla-central/source/browser/components/uitour/UITour.jsm?rev=872fa257eee2&mark=1406-1408,1437#1400
Assignee | ||
Comment 3•6 years ago
|
||
Attachment #8555410 -
Flags: review?(mdeboer)
Comment 4•6 years ago
|
||
Comment on attachment 8555410 [details] [diff] [review] Patch Review of attachment 8555410 [details] [diff] [review]: ----------------------------------------------------------------- Stealing the review since it's pretty straightforward
Attachment #8555410 -
Flags: review?(mdeboer) → review+
Assignee | ||
Comment 5•6 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/2bb76f992d1e
Points: --- → 2
Flags: qe-verify-
Flags: in-testsuite+
Flags: firefox-backlog+
https://hg.mozilla.org/mozilla-central/rev/2bb76f992d1e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 36 → Firefox 38
Updated•6 years ago
|
status-firefox37:
--- → affected
status-firefox38:
--- → fixed
Comment 7•6 years ago
|
||
Comment on attachment 8555410 [details] [diff] [review] Patch Approval Request Comment [Feature/regressing bug #]: Bug 1118874 - Hello tour/snippet/product page for 36 [User impact if declined]: Tour pages (primarily about:home snippets) cannot know if the Hello button is in the nav-bar. [Describe test coverage new/current, TreeHerder]: m-bc test added. [Risks and why]: Low risk isolated to UITour. Worst case www.mozilla.org just doesn't use problematic APIs. This is a simple addition to an existing API that was used previously. [String/UUID change made/needed]: None RyanVM/others: Note that I will do uplifts myself since there are many UITour patches to uplift in the correct order.
Attachment #8555410 -
Flags: approval-mozilla-beta?
Attachment #8555410 -
Flags: approval-mozilla-aurora?
Updated•6 years ago
|
Attachment #8555410 -
Flags: approval-mozilla-beta?
Attachment #8555410 -
Flags: approval-mozilla-beta+
Attachment #8555410 -
Flags: approval-mozilla-aurora?
Attachment #8555410 -
Flags: approval-mozilla-aurora+
You need to log in
before you can comment on or make changes to this bug.
Description
•