1115153 - Loop: Create API to allow web to retrieve the loop.gettingStarted.seen pref

Status: RESOLVED FIXED

(Firefox :: Tours, defect)

Description

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

Create new API to allow the web to get the value set in the loop.gettingStarted.seen value in about:config.

This will be used to show users different content in the /whatsnew and /firstrun tours.

Targeting Fx 36.

Comment 1

[Justin Dolske [:Dolske]]

Turns out we don't need this for whatnew, but we will for snippets. We can suppress whatsnew in-product if you've previously seen the tour, but we can't suppress snippets.

Comment 2

[Matthew N. [:MattN]]

The plan was to use getConfiguration for this. e.g. getConfiguration("loop"); and return the pref value as a property e.g. `gettingStartedSeen: true,` like we do with getConfiguration("sync") that way we can add other loop prefs later without having to have a new key for getConfiguration.

See https://mxr.mozilla.org/mozilla-central/source/browser/components/uitour/UITour.jsm?rev=872fa257eee2&mark=1406-1408,1437#1400

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 4

[Matthew N. [:MattN]]

Comment on attachment 8555410 [details] [diff] [review]
Patch

Review of attachment 8555410 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing the review since it's pretty straightforward

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/fx-team/rev/2bb76f992d1e

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2bb76f992d1e

Comment 7

[Matthew N. [:MattN]]

Comment on attachment 8555410 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: Bug 1118874 - Hello tour/snippet/product page for 36
[User impact if declined]: Tour pages (primarily about:home snippets) cannot know if the Hello button is in the nav-bar.
[Describe test coverage new/current, TreeHerder]: m-bc test added.
[Risks and why]: Low risk isolated to UITour. Worst case www.mozilla.org just doesn't use problematic APIs. This is a simple addition to an existing API that was used previously.
[String/UUID change made/needed]: None

RyanVM/others: Note that I will do uplifts myself since there are many UITour patches to uplift in the correct order.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/31a211a1b5f9

Comment 9

[Matthew N. [:MattN]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5690b3943d75