1115187 - [RTL][Bluetooth] Rename device is not mirrored

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P3)

Description

[[:RJ]]

Attachment: 2014-12-23-18-16-40.png

Description:
In blue tooth settings rename my device name text is not mirrored or aligned properly in RTL


Repro Steps:
1) Update a Flame to 20141223010202
2) Set phone to a RTL local  
3) Go to bluetooth settings 
4) tap rename device 


Actual:
text is not mirrored and seems out of alignment in RTL


Expected:
Text is mirrored and aligned  

Environmental Variables:
Device: Flame 2.2 (319mb)(Kitkat Base)(Full Flash)
Build ID: 20141223010202
Gaia: c2da2bafd4e809317e2ca70c9bf5c11136a32818
Gecko: 0532f2509f3f
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 37.0a1 (2.2)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0



Repro frequency:3/3
See attached:screenshot

Comment 1

[Dylan Oliver [:doliver]]

RTL triage: P3 -- this bug is not prioritized for inclusion in the 2.2 release.

Comment 2

[GitHub Autolander Bot]

Attachment: [PullReq] gasolin:issue-1115187 to mozilla-b2g:master

Comment 3

[[e-mail]]

Comment on attachment 8555151 [details] [review]
[PullReq] gasolin:issue-1115187 to mozilla-b2g:master

do manual test to make sure text is aligned right in arabic and aligned left(normal) in english.

For text mirror (english from left to right/arabic from right to left) I think it might be handled by gecko.

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8555151 [details] [review]
[PullReq] gasolin:issue-1115187 to mozilla-b2g:master

Arnau, could you help review the changes to shared style? Thanks.

Comment 5

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Comment on attachment 8555151 [details] [review]
[PullReq] gasolin:issue-1115187 to mozilla-b2g:master

Forwarding review to Pavel, as I won't be reviewing BB anymore :(

Comment 6

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Comment on attachment 8555151 [details] [review]
[PullReq] gasolin:issue-1115187 to mozilla-b2g:master

LGTM r+

Comment 7

[[e-mail]]

thanks!

Comment 8

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 9

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 10

[[e-mail]]

merged to master https://github.com/mozilla-b2g/gaia/commit/41d0d0cfd9171f84eec6e9dca0f3cb3f16197002

Comment 11

[[e-mail]]

Comment on attachment 8555151 [details] [review]
[PullReq] gasolin:issue-1115187 to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): feature 2.2
[User impact] if declined: input no align right
[Testing completed]: manual test passed
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: none

Comment 12

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/4bd255da09acfd03cf9e42933a8ed382d4e074d8

Comment 13

[Coler]

This issue has been verified successfully on Flame 2.2/3.0.
Reproduce rate:0/5
Attachment: Verify_RTL_BT.png

Flame 2.2 build:
Gaia-Rev        d6141fa3208f224393269e17c39d1fe53b7e6a05
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/f7414413e3a5
Build-ID        20150201002504
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150201.043120
FW-Date         Sun Feb  1 04:31:31 EST 2015
Bootloader      L1TC000118D0

Flame 3.0 build:

Gaia-Rev        ab69ae06a7f2b54e60ab63b1b44c8d19d5d20d94
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/c2359a6a6958
Build-ID        20150201010217
Version         38.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150201.044915
FW-Date         Sun Feb  1 04:49:25 EST 2015
Bootloader      L1TC000118D0

Comment 14

[Coler]

Attachment: Verify_RTL_BT.png

Comment 15

[Lancy(Leave from Mozilla)]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15662/